| Summary: | Projection is (often) not updated after pasting raster data | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tyson Tan <tysontanx> |
| Component: | Layer Stack | Assignee: | Tyson Tan <tysontanx> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | acc4commissions, halla, lynx.mw+kde |
| Priority: | NOR | Keywords: | regression, release_blocker |
| Version First Reported In: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/7768b6d0ca4f712de14a7ca07da72c70f67284fd | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Video recording of Krita's canvas not updating
Video recording of Krita nightly (df3e78e899) not updating canvas properly |
||
|
Description
Tyson Tan
2022-03-03 01:51:47 UTC
I could reproduce this on the first go. Git bisect is useless here: 54b694638bd2c943f467d66cab66754d1243fecf is identified as the breaking commit, but that only adds some hungarian translations... https://invent.kde.org/graphics/krita/-/merge_requests/888/diffs?commit_id=f6f3b6e792b2d311211e6e21acccb7b7f7ee2288 is the breaking commit. Using krita-5.1.0-prealpha-e75d194a75-x86_64.appimage Polyline tool is also causing blocks of layer to disappear. Undo/Redo doesn't help. I think these issues are related? I cannot reproduce the problem here locally. Perhaps it got fixes by my recent commit 827c03d5ddd74a4f18f55ed892f49e391ec2ecc1 ? It still happens to me with krita-5.1.0-prealpha-8f335dfa46-x86_64.appimage Did your new document have only one Background layer, and you filled and cut on that layer? I could not trigger the bug that way either. But I can trigger the bug by creating a new paint layer, then fill, cut, paste over it. The reason you might have one Background layer is caused by this bug: BUG431164 With current master, I cannot reproduce it anymore either. (I have a background layer, one layern filled with a gradient, from which I cut & paste into a new layer) I can still reproduce this with krita-5.1.0-prealpha-8f335dfa46-x86_64.appimage exactly like what I mentioned. Created attachment 147529 [details]
Video recording of Krita's canvas not updating
This is a video of Krita's canvas not updating. Tested with krita-5.1.0-prealpha-8f335dfa46-x86_64.appimage
Looks like it was fixed in krita-5.1.0-prealpha-df3e78e899-x86_64.appimage Thank you! :) Created attachment 147562 [details]
Video recording of Krita nightly (df3e78e899) not updating canvas properly
I'm sorry but later that day the same bug happened to krita-5.1.0-prealpha-df3e78e899-x86_64.appimage
I recorded a video here.
The same thing happened to today's krita-5.1.0-prealpha-dd368ef73f-x86_64.appimage too. I have restarted the computer before the testing. Nothing else was running at the same time. krita-5.0.2-alpha-ca4f0c8d6a-x86_64.appimage still worked fine. I've been having this problem too for a long time. For me the canvas projection corrupts sometimes too when I'm using transform, undo, etc. But I have no idea it's related. Sometime similar to the bug description happened to Krita 5.0.6 nightly too, if just for once. I was doing: 1. Create a new text object, edited it. 2. Tried to transform it but failed because it was vector 3. Convert the vector layer to raster layer 4. Copy the rasterized text layer 5. Paste, then transform. 6. Paste again, this time nothing is shown on canvas, but after toggling layer visibility the pasted content showed up. The pasted layers might have been inside of a Group. I could not reproduce this situation again, but it did happened, so I thought I should put it here for information. Today I found out that if I first duplicate a layer and then immediately remove it, the subsequent cut-and-paste action will not be affected by this bug. It's not really a workaround, but it might hold some clue to solve this issue? Git commit 7768b6d0ca4f712de14a7ca07da72c70f67284fd by Dmitry Kazakov. Committed on 03/06/2022 at 07:24. Pushed by dkazakov into branch 'master'. Fix a race condition in KisNodeJugglerCompressed's updates It could happen that the updates would be issued **bofore** the layer is actually added to the image. It happened because the updates were issued by the GUI thread, but addition is executed by the stroke's thread. Now the juggler pushes the updates into the common strokes queue, so that they cannot be reordered. M +15 -2 libs/ui/kis_node_juggler_compressed.cpp https://invent.kde.org/graphics/krita/commit/7768b6d0ca4f712de14a7ca07da72c70f67284fd Thank you, Dmitry! Now I can finally use the Krita next nightlies at production XD |