Bug 450950

Summary:	Discover blindly installs first file for content with multiple files available, instead of asking the user and letting them choose, as the GHNS dialog does
Product:	[Applications] Discover	Reporter:	Bernie Innocenti <bernie>
Component:	KNewStuff Backend	Assignee:	Dan Leinir Turthra Jensen <leinir>
Status:	CONFIRMED ---
Severity:	normal	CC:	aleixpol, nate, postix
Priority:	NOR
Version:	master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	knewstuff offering to download either v25 or v26

Description Bernie Innocenti 2022-02-28 05:30:32 UTC

STEPS TO REPRODUCE
1. Open plasma-discover
2. Search for "win7 volume"
3. Note how the version reported in the UI is "26, released on 01/12/2020"
3. Click Install
4. A new volume applet will appear in the System Tray
5. Right-click on it and select "Audio Volume Settings..."
6. In the settings dialog, go to About

OBSERVED RESULT
"Audio Volume (Win7 Mixer) 25"

.local/share/plasma/plasmoids/org.kde.plasma.volumewin7mixer/metadata.desktop also contains "X-KDE-PluginInfo-Version=26"

EXPECTED RESULT
Version 26 should have been installed.

If you download volumewin7mixer-v26-plasma5.12.plasmoid from https://store.kde.org/p/1100894/ and unzip it in the right place, you'll get version 26.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
KDE Plasma Version: 5.25.80 (git)
KDE Frameworks Version: 5.92.0
Qt Version: 5.15.2 + kde

Comment 1 Nate Graham 2022-03-21 03:23:17 UTC

Does the same thing happen if you download it from the "Add new widgets" dialog that's accessed from the Widget Explorer sidebar?

Comment 2 Bernie Innocenti 2022-03-21 08:51:39 UTC

Created attachment 147647 [details]
knewstuff offering to download either v25 or v26

Comment 3 Bernie Innocenti 2022-03-21 08:52:19 UTC

(In reply to Nate Graham from comment #1)
> Does the same thing happen if you download it from the "Add new widgets"
> dialog that's accessed from the Widget Explorer sidebar?

Not the same thing: the knewstuff dialog gives me an option to install either v25 or v26 (see screenshot on comment #2).

Comment 4 Nate Graham 2022-03-21 13:55:15 UTC

Thanks. Then the problem seems to be that Discover has no such UI, and instead blindly picks the first file in the list. Since version 25 is the first file here, that's what you get.

Personally I think we should rip out GHNS browsing and installing functionality from Discover and let the user find this content purely through the get how new stuff dialogs, so that there's only ever a single UI used for it, and we can focus on making that one UI great, rather than splitting resources across two UIs each with different bugs.