Bug 450835

Summary: Shows irrelevant and misleading bind mounts with Flatpak packaging
Product: [Applications] filelight Reporter: Nate Graham <nate>
Component: generalAssignee: Martin Sandsmark <martin.sandsmark>
Status: RESOLVED FIXED    
Severity: normal CC: sitter
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/utilities/filelight/commit/e30f05c2a27a62a9eb8641fa594a331077eb4d28 Version Fixed/Implemented In: 22.04
Sentry Crash Report:

Description Nate Graham 2022-02-25 17:20:38 UTC 
I am working on packaging Filelight for Flathub, and I'm running into the following issue with the 21.12.2 version:

STEPS TO REPRODUCE
1. Launch the app

OBSERVED RESULT
The main view shows dozens of entries for Flatpak-specific bind mounts that are not relevant to the user and are even actively misleading as they show random-looking used/free values.

EXPECTED RESULT
The Flaptak-specific bind mounts are filtered out automatically so that only real volumes appear.

ADDITIONAL INFORMATION
Does not affect the non-Flatpak version, obviously. :) 

You can see my draft Flatpak manifest here: https://github.com/Pointedstick/flathub/blob/filelight/org.kde.filelight.json
Comment 1 Harald Sitter 2022-02-28 08:23:48 UTC 
I find it hard to care about this with the file not being in our repo.
Comment 2 Nate Graham 2022-02-28 14:22:54 UTC 
It's located there because to submit something to FlatHub, you have to fork their upstream GitHub repo and send a pull request. Not my preference, but that's the workflow.
Comment 3 Harald Sitter 2022-02-28 14:50:55 UTC 
I was under the impression we maintain our recipes somewhere on our infrastructure :O

At any rate, I would expect the canonical recipe to be in our repo, not some rando repo on github, for all I care it could be copied there or something.
Comment 4 Nate Graham 2022-02-28 17:15:23 UTC 
We maintain Flatpak manifests at https://invent.kde.org/packaging/flatpak-kde-applications which are set up for nightly builds, not stable builds. And even if they were, those aren't set up for direct submission to FlatHub from their current location. The workflow seems to be incompatible with how FlatHub expects app submissions and updates.
Comment 5 Bug Janitor Service 2022-03-21 08:27:12 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/utilities/filelight/-/merge_requests/21
Comment 6 Harald Sitter 2022-03-29 10:47:26 UTC 
Git commit e30f05c2a27a62a9eb8641fa594a331077eb4d28 by Harald Sitter.
Committed on 29/03/2022 at 10:33.
Pushed by sitter into branch 'release/22.04'.

do not show silly mounts in sandboxed envs

inside sandboxes we get all sorts of silly mounts that have no real
value. since the list of potential mounts is fairly long I've opted to
skip over all readonly mounts as well as all of /var and a special
app-specific var variant. inside flatpak that covers everything of no
value pretty much

M  +11   -0    src/summaryWidget.cpp

https://invent.kde.org/utilities/filelight/commit/e30f05c2a27a62a9eb8641fa594a331077eb4d28