Bug 450790

Hi Rexel,

Thanks for the Krita files and bug report. I can confirm that the hold frame option doesn't work/crashes for your krita file file. 

Setting to confirmed and assigning to myself since I added that feature.

Same issue here.

After few tries, I find that if changing the image size midway, the loop last frame option will not work.

Maybe a ffmpeg bug  or misconfiguration of ffmpeg parameters?

Hi, I think my issue #461869 is related: https://bugs.kde.org/show_bug.cgi?id=461869 (I share on it a workaround, if it helps).

I'm fairly sure its not related to that other bug. I think that one is mostly from some of the ffmpeg commands not properly taking into account the input fps. This one seems to be some other issue that just skips part of the script entirely. Its possible the scaling caused the issue but will probably take some more testing to confirm.

After some testing it seems like it is the different resolution for the saved images (from the painting changing sizes midway). Checking the ffmpeg docs it says "The _size_, the pixel format, and the format of each image must be the same for all the files in the sequence." Trying a simple ffmpeg command to extend a custom frame it breaks exactly when the input image resolution changes. 

It does seem like the preview still works (probably because it gets and reads the extended portion separately from the main file) so I think doing the same for the end result should get around the issue.

fmmpeg doc: https://ffmpeg.org/ffmpeg-all.html#image2-1

I'm now not totally sure it is a scale issue. I tried using the same  method to extend a frame as the preview and use it for the end but that doesn't seem to work. ffmpeg just seems to skip rendering that portion entirely if its added to the end.

I found this a comment on stack overflow that mentions exactly what I thought was the problem (different resolutions for input images) but trying that doesn't seem to fix the issue here. https://superuser.com/a/1136305 and ffmpeg doc https://ffmpeg.org/ffmpeg-filters.html#scale

I'm not quite sure what else to try/test if anyone has any ideas...

Here was my last ffmpeg filter command I was testing with for visibility:

```
 [0]scale=w=$WIDTH:h=$HEIGHT:force_original_aspect_ratio=decrease:eval=frame[main1];
 [main1]loop=1:size=1:start=0[main2];
 [main2]setpts=PTS-STARTPTS[main3];
 [1]split=3 [preview1][transition1][ending1];
 [transition1]scale=$WIDTH:$HEIGHT:force_original_aspect_ratio=decrease:eval=frame [transition2];
 [transition2]loop='if(gte($FIRST_FRAME_SEC, 1), 1*$IN_FPS, 0)':size=1:start=1[transition3];
 [transition3]setpts=PTS-STARTPTS[transition4];
 [preview1]loop='if(gte($FIRST_FRAME_SEC, 1), ($FIRST_FRAME_SEC*$IN_FPS) - 0.5*$IN_FPS, $FIRST_FRAME_SEC*$IN_FPS)':size=1:start=1[preview2];
 [preview2]scale=$WIDTH:$HEIGHT:force_original_aspect_ratio=decrease:eval=frame[preview3];
 [preview3]setpts=PTS-STARTPTS[preview4];
 [ending1]loop=$LAST_FRAME_SEC*$IN_FPS:size=1:start=1[ending2];
 [ending2]scale=$WIDTH:$HEIGHT:force_original_aspect_ratio=decrease:eval=frame[ending3];
 [ending3]setpts=PTS-STARTPTS[ending4];
 [transition4][main3]xfade=transition=smoothright:duration=0.5:offset=0[combined1];
 [combined1]trim=start_frame=1[combined2];
 [combined2]scale=$WIDTH:$HEIGHT:force_original_aspect_ratio=decrease:eval=frame[combined3];
 [ending4][combined3]scale2ref[ending5][combined4] ;
 [preview4][combined4][ending5] concat=n=3[final1];
 [final1] setpts=PTS-STARTPTS[final2];
 [final2] trim=start_frame=1
```

Git commit 40524a339fc519cec62ed6e1fab663e923111635 by Emmet O'Neill, on behalf of Ralek Kolemios.
Committed on 01/05/2024 at 22:07.
Pushed by emmetoneill into branch 'master'.

Reworked default FFmpeg profiles
Related: bug 455006, bug 429326, bug 485515, bug 485514

M  +2    -0    plugins/dockers/recorder/recorder_export.cpp
M  +166  -147  plugins/dockers/recorder/recorder_export_config.cpp
M  +1    -0    plugins/dockers/recorder/recorder_profile_settings.ui

https://invent.kde.org/graphics/krita/-/commit/40524a339fc519cec62ed6e1fab663e923111635

Git commit 47961a1a9c3322bfae8250cb9d3f8114af07cc7d by Freya Lupen, on behalf of Ralek Kolemios.
Committed on 05/06/2024 at 19:10.
Pushed by freyalupen into branch 'krita/5.2'.

Reworked default FFmpeg profiles
Related: bug 455006, bug 429326, bug 485515, bug 485514

 Conflicts:
	plugins/dockers/recorder/recorder_export.cpp
	plugins/dockers/recorder/recorder_export_config.cpp

(cherry-picked from commit 40524a33)

M  +2    -0    plugins/dockers/recorder/recorder_export.cpp
M  +166  -147  plugins/dockers/recorder/recorder_export_config.cpp
M  +1    -0    plugins/dockers/recorder/recorder_profile_settings.ui

https://invent.kde.org/graphics/krita/-/commit/47961a1a9c3322bfae8250cb9d3f8114af07cc7d