Summary: | Transform mask animations don't work after scaling image down. | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | yockeyjim <yockeyjim> |
Component: | Animation | Assignee: | Eoin O'Neill <eoinoneill1991> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ahab.greybeard, eoinoneill1991 |
Priority: | NOR | ||
Version: | 5.0.2 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Microsoft Windows | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/11ca47e723492925588ff34800aa25e8a04cbf41 | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: | Mis-aligned image on later frame. |
Description
yockeyjim@yahoo.com
2022-02-24 02:27:02 UTC
I can Confirm this for the 5.0.2 and the Feb 24 5.1.0-prealpha (git 96871c7) appimages on Debian 10. After scaling, the animated transform mask is identical, as seen in the Animation Curved docker but it does not work. You can add control points but they have no effect A Duplicate of the animated transform mask has no content. After Saving and re-Opening, the animated transform mask has no content and if you try to create a control point, all parameters are Zero. If you use the Transform Tool to move the location of a frame, there is no response in the transform mask Animation Curves docker. A newly made animated transform mask behaves normally. Git commit 069dd6baa083c21d9dd8960da4af73aab7efc3c3 by Eoin O'Neill. Committed on 24/02/2022 at 23:15. Pushed by eoinoneill into branch 'master'. We now prevent data loss when scaling an image w/ animated transform masks. The ideal long-term fix would be to modify transform mask keyframes to account for new image size. When the image size changes, positioning data should change to reflect new image sizing. For now, this is enough to at least prevent data loss. M +1 -1 libs/image/processing/kis_transform_processing_visitor.cpp M +12 -0 plugins/tools/tool_transform2/kis_animated_transform_parameters.cpp https://invent.kde.org/graphics/krita/commit/069dd6baa083c21d9dd8960da4af73aab7efc3c3 Git commit 11ca47e723492925588ff34800aa25e8a04cbf41 by Eoin O'Neill. Committed on 12/04/2022 at 05:29. Pushed by eoinoneill into branch 'krita/5.0'. We now prevent data loss when scaling an image w/ animated transform masks. The ideal long-term fix would be to modify transform mask keyframes to account for new image size. When the image size changes, positioning data should change to reflect new image sizing. For now, this is enough to at least prevent data loss. (cherry picked from commit 069dd6baa083c21d9dd8960da4af73aab7efc3c3) M +1 -1 libs/image/processing/kis_transform_processing_visitor.cpp M +12 -0 plugins/tools/tool_transform2/kis_animated_transform_parameters.cpp https://invent.kde.org/graphics/krita/commit/11ca47e723492925588ff34800aa25e8a04cbf41 |