Bug 450517

Summary: No result in quick filter with "C++"
Product: [Applications] tellico Reporter: Fabiano Caruana <bugzilla>
Component: generalAssignee: Robby Stephenson <robby>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 3.4.4   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 3.5
Attachments: Quick filter "C++"

Description Fabiano Caruana 2022-02-18 13:10:05 UTC
Created attachment 146910 [details]
Quick filter "C++"

Hi Robby,

The expression "C++" is not found in the quick filter. Nothing happens, it looks like the expression is just ignored. The expression "++" is found.
The advanced filter finds the expression "C++".

greetings
Udo

OBSERVED RESULT
nothing


EXPECTED RESULT
two books

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: OpenSuse 15.3 Kernel 5.3.18-150300.59.49
(available in About System)
KDE Plasma Version: 5.18.6
KDE Frameworks Version: 5.76.0
Qt Version: 5.12.7

ADDITIONAL INFORMATION
Comment 1 Robby Stephenson 2022-02-19 20:18:41 UTC
(In reply to Fabiano Caruana from comment #0)
> The expression "C++" is not found in the quick filter. Nothing happens, it
> looks like the expression is just ignored. The expression "++" is found.
> The advanced filter finds the expression "C++".

Tellico tries to be helpful and interpret C++ as a regular expression which ends up matching any book with the letter 'c' in any field. Try searching for c\+\+ to see if that gives you your expected outcome.

But yes, this is unhelpful and surprising to a user. I need to improve it. Maybe an option to enable/disable the parsing as a regular expression would be most appropriate.
Comment 2 Robby Stephenson 2022-02-19 20:20:18 UTC
Git commit f3b233907632e85aa0ff6c45e78f7662459a3592 by Robby Stephenson.
Committed on 19/02/2022 at 20:19.
Pushed by rstephenson into branch '3.4'.

Isolate the main window quick filter to allow unit testing

M  +29   -0    src/filter.cpp
M  +2    -0    src/filter.h
M  +1    -23   src/mainwindow.cpp
M  +12   -0    src/tests/filtertest.cpp
M  +1    -0    src/tests/filtertest.h

https://invent.kde.org/office/tellico/commit/f3b233907632e85aa0ff6c45e78f7662459a3592
Comment 3 Robby Stephenson 2022-03-16 01:25:20 UTC
Git commit 9f93fa8921c90119e3d1e0ddd58a3d316c6fba60 by Robby Stephenson.
Committed on 16/03/2022 at 01:15.
Pushed by rstephenson into branch 'master'.

Add option for using regular expressions in the quick filter
FIXED-IN: 3.5

M  +4    -0    ChangeLog
M  +2    -1    doc/configuration.docbook
M  +3    -0    src/config/tellico_config.kcfg
M  +8    -0    src/configdialog.cpp
M  +1    -0    src/configdialog.h
M  +2    -2    src/filter.cpp
M  +1    -1    src/filter.h
M  +1    -1    src/mainwindow.cpp
M  +13   -1    src/tests/filtertest.cpp

https://invent.kde.org/office/tellico/commit/9f93fa8921c90119e3d1e0ddd58a3d316c6fba60