| Summary: | Cannot drag and drop file into opened VLC window (XWayland) but rather onto VLC's taskmanager icon, which creates a new VLC instance | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | postix <postix> |
| Component: | wayland-generic | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, erik.paladin, i6icgp6, kde, nate, notmart, postix, sundman |
| Priority: | NOR | Keywords: | wayland |
| Version: | 5.24.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/20a94d71577d39d92d72cb2d74f49414cd1f72d6 | Version Fixed In: | 5.25 |
| Sentry Crash Report: | |||
|
Description
postix
2022-02-17 14:11:02 UTC
I tested it also with IntelliJ PyCharm, which runs under XWayland, here DND does not work too, but dropping a file onto the taskmanager icon also does not create a new instance. For me, no new instance is created when I drag the file on the Task Manager icon. That works as expected, appending the dropped file onto the existing playlist (if any). and playing it I can reproduce nothing happening when a file is dropped on the main window though. *** Bug 452266 has been marked as a duplicate of this bug. *** can reproduce, needs investigation When the drag is dropped SeatInterface emits dragEnded(), at this point the data source is reset and the drag object deleted: https://invent.kde.org/plasma/kwin/-/blob/master/src/xwayland/dnd.cpp#L165 VLC will only ask for data after the drop has happened but at that point since wlsource is null we just ignore it: https://invent.kde.org/plasma/kwin/-/blob/master/src/xwayland/selection.cpp#L238 Git commit 20a94d71577d39d92d72cb2d74f49414cd1f72d6 by David Edmundson, on behalf of David Redondo. Committed on 19/05/2022 at 06:45. Pushed by davidre into branch 'master'. xwayland: Keep source/Xvisit alive for longer SeatInterface emits dragEnded when the drag is dropped. The target may want to interact with the data source after the drop happened, for example only fetching data after the drop and not during the drag. (Note that the Wayland protocol has the same Xvisits are now not deleted prematurely but only when they are really finished. (Note that the Wayland protocol has the same distinction between dropped and finished so it maps nicely). For storing previous visits the same code pattern as in the rest of the XWayland DND code is used. The SelectionSource is reset when the next Drag/Drop operation involving a X window is started (see startDrag and doHandleXfixesNotify) or when the Wayland source is about to be deleted. FIXED-in:5.25.0 M +8 -7 src/xwayland/dnd.cpp M +15 -1 src/xwayland/xwldrophandler.cpp M +1 -0 src/xwayland/xwldrophandler.h https://invent.kde.org/plasma/kwin/commit/20a94d71577d39d92d72cb2d74f49414cd1f72d6 *** Bug 458611 has been marked as a duplicate of this bug. *** |