Bug 450424

Summary:	Cached Animation Playback Not Respecting Multiple Views To Same Canvas
Product:	[Applications] krita	Reporter:	Eoin O'Neill <eoinoneill1991>
Component:	Animation	Assignee:	Eoin O'Neill <eoinoneill1991>
Status:	RESOLVED FIXED
Severity:	minor	CC:	halla
Priority:	NOR
Version First Reported In:	5.0.0-beta5
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Eoin O'Neill 2022-02-17 03:43:48 UTC

SUMMARY
Multiple views to the same animation (when graphics acceleration is enabled) will not update both views simultaneously. You must be in subwindow mode or have a separate window in order to see multiple views of the same canvas. 


STEPS TO REPRODUCE
1. Enable subwindow mode or instantiate second window 
2. Create a duplicate view (or window w/ duplicate view)
3. Play animation back 

OBSERVED RESULT
One view will animate correctly, the other one won't.

EXPECTED RESULT
Both views should update appropriately.

Comment 1 Eoin O'Neill 2022-02-18 00:47:50 UTC

Git commit e1d1a23bac0abfc7f1b5d9c477d32e689b657c48 by Eoin O'Neill.
Committed on 18/02/2022 at 00:40.
Pushed by eoinoneill into branch 'master'.

Bugfix: Playback between multiple views / canvas now works correctly

(Minus caching uploads, those need to happen even when view is no
longer selected.)
Related: bug 450425

M  +4    -0    plugins/dockers/animation/KisAnimCurvesDocker.cpp
M  +2    -0    plugins/dockers/animation/KisAnimTimelineDocker.cpp
M  +16   -9    plugins/dockers/animation/KisTimeBasedItemModel.cpp

https://invent.kde.org/graphics/krita/commit/e1d1a23bac0abfc7f1b5d9c477d32e689b657c48

Comment 2 Eoin O'Neill 2022-04-12 05:33:21 UTC

Git commit d6e6451922e0f78e823554c6cc9eebbbe7b880b5 by Eoin O'Neill.
Committed on 12/04/2022 at 05:29.
Pushed by eoinoneill into branch 'krita/5.0'.

Bugfix: Playback between multiple views / canvas now works correctly

(Minus caching uploads, those need to happen even when view is no
longer selected.)
Related: bug 450425
(cherry picked from commit e1d1a23bac0abfc7f1b5d9c477d32e689b657c48)

M  +4    -0    plugins/dockers/animation/KisAnimCurvesDocker.cpp
M  +2    -0    plugins/dockers/animation/KisAnimTimelineDocker.cpp
M  +16   -9    plugins/dockers/animation/KisTimeBasedItemModel.cpp

https://invent.kde.org/graphics/krita/commit/d6e6451922e0f78e823554c6cc9eebbbe7b880b5