Bug 450355

Summary: Partition Manager: Make refreshing devices more intuitive in the GUI
Product: [Applications] partitionmanager Reporter: Michael <kde>
Component: generalAssignee: Andrius Štikonas <andrius>
Status: RESOLVED FIXED    
Severity: minor    
Priority: NOR    
Version First Reported In: 21.12.2   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: we see the Refresh Devices string in the Tools menu
the Device menu is where the suggestion is to put the Refresh Devices string

Description Michael 2022-02-16 02:46:59 UTC
SUMMARY

Every time I use Partition Manager (great program, BTW!), I eventually need to refresh the device list. 

And I always wind up hunting around for the the "Refresh Devices" command. I instinctively look in the Devices menu, but it's not there. There's no equivalent "Refresh" button in the GUI by default. Yes, I can add it, but I feel it's a common action.

EXPECTED RESULT

My suggestions are to 

1) move the "Refresh Devices" menu item from Tools menu to Device menu where it's expected to be

2) add the "Refresh Devices" button to the toolbar by default


SOFTWARE/OS VERSIONS

Operating System: KDE neon 5.24
KDE Plasma Version: 5.24.0
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.3
Kernel Version: 5.13.0-28-generic (64-bit)
Graphics Platform: X11
Comment 1 Andrius Štikonas 2022-02-16 21:39:11 UTC
I guess we can add a button... Although I myself always use just F5 (same as in the browsers) for refreshing.
Comment 2 Andrius Štikonas 2022-02-16 21:41:33 UTC
Oh actually I just checked, there isn't "Devices" menu. There is only "Device" menu but then if we add action to it, it would also appear when right clicking on device elsewhere in GUI, not just in menu. Wouldn't that be confusing?

Maybe instead we should add a button to toolbar?
Comment 3 Michael 2022-02-17 05:23:50 UTC
Created attachment 146848 [details]
we see the Refresh Devices string in the Tools menu
Comment 4 Michael 2022-02-17 05:25:24 UTC
Created attachment 146849 [details]
the Device menu is where the suggestion is to put the Refresh Devices string
Comment 5 Michael 2022-02-17 05:26:57 UTC
"Oh actually I just checked, there isn't "Devices" menu."

Huh? On my English setup there are seven menus: File, Edit, *Device*, Partition, Tools, Settings, and Help. I've attached a screenshot.

"There is only "Device" menu but then if we add action to it, it would also appear when right clicking on device elsewhere in GUI, not just in menu. Wouldn't that be confusing?"

I'm not sure I understand. If you move the string from the Tools menu that says "Refresh Devices   F5" and instead put it under the Device menu, how would that also appear when right-clicking on a device? Aren't main menus independent of right-click menus?

"Maybe instead we should add a button to toolbar?"

Well, why not both? But yes, that's what I was suggesting: let's add a button to the toolbar.
Comment 6 Andrius Štikonas 2022-02-17 10:40:41 UTC
(In reply to Michael from comment #5)
> "Oh actually I just checked, there isn't "Devices" menu."
> 
> Huh? On my English setup there are seven menus: File, Edit, *Device*,
> Partition, Tools, Settings, and Help. I've attached a screenshot.
> 
> "There is only "Device" menu but then if we add action to it, it would also
> appear when right clicking on device elsewhere in GUI, not just in menu.
> Wouldn't that be confusing?"
> 
> I'm not sure I understand. If you move the string from the Tools menu that
> says "Refresh Devices   F5" and instead put it under the Device menu, how
> would that also appear when right-clicking on a device? Aren't main menus
> independent of right-click menus?

No, that's the same menu there. They are not independent. Basically the idea for Device menu (note singular, not plural Devices) is that it contains actions specific to that device, e.g. /dev/sda.

> 
> "Maybe instead we should add a button to toolbar?"
> 
> Well, why not both? But yes, that's what I was suggesting: let's add a
> button to the toolbar.
Comment 7 Michael 2022-02-18 06:33:03 UTC
Okay, after playing with it some more I see what you mean, the menu seems to be shared between the main menu and the right-click context.

Still, I don't think it would be out of place to have a menu entry in the right-click context menu that says "Refresh Devices". It would be clear that it's refreshing all the devices because it's plural, not singular.

I'll circle back to my main issue which was that this action is not discoverable in the menu it currently resides in. I've been using Partition Manger for years and I still need to hunt around to find it in the menus. Knowing that F5 is the equivalent can only be known once the menu item is found, which has not been intuitive for me.
Comment 8 Andrius Štikonas 2022-02-20 00:29:31 UTC
Git commit 58617c1e52dc468df1e77180d3865028ea505fcd by Andrius Štikonas.
Committed on 20/02/2022 at 00:28.
Pushed by stikonas into branch 'master'.

Make refreshing devices more intuitive in the GUI.

M  +2    -1    src/gui/partitionmanagerui.rc

https://invent.kde.org/system/partitionmanager/commit/58617c1e52dc468df1e77180d3865028ea505fcd
Comment 9 Michael 2022-02-21 02:04:59 UTC
Thank you! 🙂