Bug 450334

Summary:	"Search for... in this document" item in Text Selection context menu does not truncate new lines
Product:	[Applications] okular	Reporter:	Jack Hill <jackhill3103>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED FIXED
Severity:	minor	CC:	aacid, andreas.naumann
Priority:	NOR	Keywords:	junior-jobs
Version First Reported In:	21.12.2
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/okular/commit/28e362b6a17e9d5d631548facbc6e4d8cba5a177	Version Fixed In:
Sentry Crash Report:
Attachments:	Bad "Search for..." item

Description Jack Hill 2022-02-15 19:18:43 UTC

Created attachment 146786 [details]
Bad "Search for..." item

SUMMARY


STEPS TO REPRODUCE
1. Highlight some multi-line text with the Text Selection tool
2. Right click
3. Look at the "Search for... in this document" item

OBSERVED RESULT
The first new line is not ignored so the menu item looks odd

EXPECTED RESULT
New lines should be ignored

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE 20220213
KDE Plasma Version: 5.24.0
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
The "Search for... with" item does not have this issue

Comment 1 Bug Janitor Service 2022-02-17 13:10:53 UTC

A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/565

Comment 2 Yuri Chornoivan 2022-02-17 14:22:57 UTC

Git commit 28e362b6a17e9d5d631548facbc6e4d8cba5a177 by Yuri Chornoivan.
Committed on 17/02/2022 at 13:09.
Pushed by aacid into branch 'master'.

Simplify the string for the 'Search for...' action

M  +1    -1    part/pageview.cpp

https://invent.kde.org/graphics/okular/commit/28e362b6a17e9d5d631548facbc6e4d8cba5a177