| Summary: | "Show titlebar button tooltips" option should be removed and controlled instead by global option in General Behavior KCM | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | guimarcalsilva |
| Component: | kcm_kwindecoration | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | wishlist | CC: | 4wy78uwh, nate, plasma-bugs-null, postix |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
guimarcalsilva
2022-02-15 00:57:53 UTC
Yeah that's a good point. Having multiple settings in different places that control the same thing at different levels is always a bit of a UX smell. Would you be interested in submitting a merge request? This probably isn't that hard to change. (In reply to Nate Graham from comment #1) > Yeah that's a good point. Having multiple settings in different places that > control the same thing at different levels is always a bit of a UX smell. > > Would you be interested in submitting a merge request? This probably isn't > that hard to change. I found two places where I think deleting some code would get rid of the option. One is between lines 40 to 44: https://invent.kde.org/plasma/kwin/-/blob/master/src/kcmkwin/kwindecoration/kwindecorationsettings.kcfg and another is between lines 165 to 175 (hopefully I'm including the right brackets): https://invent.kde.org/plasma/kwin/-/blob/master/src/kcmkwin/kwindecoration/package/contents/ui/main.qml but I feel that's not all. Shouldn't showToolTips also be somewhere in a .cpp file somewhere? Otherwise, how would the code know what the option should do? I can't find it anywhere. Check out src/decorations/decoratedclient.cpp. Found that by grepping for `showToolTips` in the entire KWin repo. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2071 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2072 There is some confusion here, from myself as well. I recently learned that the option in question is not in fact a global option, and only affects Plasma panel tooltips. It's definitely not clear. The current plan is to delete the option entirely, but we might end up being convinced to instead simply move it into the Panel settings window to make it clear that it's a Panel-specific setting. There is no chance we'll actually make it a global setting that applies to all tooltips including this one, as such a thing would be practically impossible end end up being a "broken promise" setting; see https://community.kde.org/Get_Involved/Design/Lessons_Learned#%22Broken_promise%22_global_options. |