Bug 450148

Summary:	Mount Model Tool save buttons confuse + bonus improvements suggestions
Product:	[Applications] kstars	Reporter:	luzik
Component:	general	Assignee:	Rob <rlancaste>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	3.5.7
Target Milestone:	---
Platform:	macOS (DMG)
OS:	macOS
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description luzik 2022-02-13 11:16:50 UTC

Ekos -> align -> Mount Model have two save buttons with same help message and different icons. They seams to do same thing but maybe one is for 'save' and other is for 'save as', if so ..then when new list is created 'save' should be disable, only 'save as' should be available.

Also under Mac OS it ask two times for overwrite, one with macOS native window, and second time as kstars alert

Also please consider autoloading last used 'mount model alignment points'

3rd Also ..please consider taking 'artificial horizon' into account while generating list of alignment points and list of visible stars

Comment 1 Rob 2022-03-19 23:49:50 UTC

You are quite right.  I experimented a little with this today.  Yes they were "save" and "save as" buttons.  But yeah, you are right, it did ask twice on my Mac about overwriting existing files.  I also tested on Linux and it did the same.  So if the file browser does it, there is really no need to do it again.  So yeah I just removed that.  But in a similar light, there really is no need to have two buttons.  so I just made a change to leave just one button that will have the save as functionality but will select the last file opened or saved so you can overwrite.  That will almost work just like the save button did before, with the added advantage that you have to think for a minute about whether you want to overwrite it or save with a different name, so I think that is a benefit actually.

Autoloading is also not a bad idea, let me think about that.  That might be a plus because then you could just start up kstars and start the automatic alignment routine.

Comment 2 Rob 2022-03-19 23:53:11 UTC

There is a problem with that idea, that is different nights or times might have different alignment points since as the time goes on, some of the points will go below the horizon.

Comment 3 Rob 2022-03-19 23:54:45 UTC

We could have an option to automatically generate an alignment list and run through the routine on startup.

Comment 4 Rob 2022-06-05 15:32:05 UTC

I believe this issue was resolved with a change I made a few months ago, can you please check to see if it is fixed?