| Summary: | Custom default look and feel isn't fully applying on Plasma 5.24, in particular the panel theme | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Neal Gompa <ngompa13> |
| Component: | kcm_lookandfeel | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED DOWNSTREAM | ||
| Severity: | major | CC: | agurenko, jgrulich, kde, nate, ngompa13, postix, rdieter, tdawson |
| Priority: | NOR | ||
| Version: | 5.24.0 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Neal Gompa
2022-02-12 04:20:38 UTC
This is considered a serious issue for Fedora KDE and has a downstream RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=2053790 (In reply to Neal Gompa from comment #1) > This is considered a serious issue for Fedora KDE and has a downstream RHBZ: > https://bugzilla.redhat.com/show_bug.cgi?id=2053790 This has now been upgraded to a F36 blocker bug. So, I don't fully understand why, but I needed to refresh the downstream Fedora patch for setting the default theme to set in startkde/startplasma.cpp: https://src.fedoraproject.org/rpms/plasma-workspace/c/1857efd5370f81b74025578a9fbc0250bde7abf8?branch=1857efd5370f81b74025578a9fbc0250bde7abf8 It fixes the problem for me, but I feel like the setting I made in kde-settings should have worked, though it didn't: https://pagure.io/fedora-kde/kde-settings/c/3cd46daaf3a2fcfb8266364eed37ab7744760eb7 https://bugzilla.redhat.com/show_bug.cgi?id=2053790 seems to be closed now; did you work around this with a packaging change, or was there some leftover upstream patch that needed to be cleared out? Or something else? (In reply to Nate Graham from comment #4) > https://bugzilla.redhat.com/show_bug.cgi?id=2053790 seems to be closed now; > did you work around this with a packaging change, or was there some leftover > upstream patch that needed to be cleared out? Or something else? I worked around it with the patch I noted in comment 3, which basically persists the problems we have around theming but at least doesn't break the default setup anymore. So Fedora ships /usr/share/kde-settings/kde-profile/default/share/config/kdeglobals in https://pagure.io/fedora-kde/kde-settings/c/3cd46daaf3a2fcfb8266364eed37ab7744760eb7 that sets LookAndFeelPackage=org.fedoraproject.fedora.desktop I assume /usr/share/kde-settings/kde-profile/default/share/config/ is not in $XDG_CONFIG _DIRS. Fedora also ships an /etc/kderc which reads [Directories] profileDirsPrefix=/usr/share/kde-settings/kde-profile/ [Directories-default] prefixes=/usr/share/kde-settings/kde-profile/default/ This seems to to be an kde4 era mechanism to do some things https://lxr.kde.org/search?%21v=kf5-qt5&_filestring=&_string=profileDirsPrefix That aside /etc/kderc is not used by frameworks5 kconfig, I assume that's also a kde 4 era file. The correct file would be /etc/kde5rc https://invent.kde.org/frameworks/kconfig/-/blob/master/src/core/kconfig.cpp#L98 Fedora needs to actually set the setting in a file that is respected . Typically this would be /etc/xdg/kdeglobals or some other kdeglobals in $XDG_CONFIG_DIRS (If one really wants it even /etc/kde5rc). The patch from comment #3 i.e. https://src.fedoraproject.org/rpms/plasma-workspace/c/1857efd5370f81b74025578a9fbc0250bde7abf8?branch=1857efd5370f81b74025578a9fbc0250bde7abf8 is only half correct since it only changes the code default when reading the setting. When global theme is changed in KCM to the one it thinks is the default one (Breeze Light,) it doesn't write it down to any config file because the current default matches the code default. So when startplasma reads that setting it uses the code provided default and thinks the Fedora global theme is active but not correctly applied and acivates it. Tl;dr: Fedora is using a weird file/a file that does not have any effect. *** Bug 453083 has been marked as a duplicate of this bug. *** |