| Summary: | KDialog progress bar doesn't go to 100% | ||
|---|---|---|---|
| Product: | [Applications] kdialog | Reporter: | Nicholas Redgrave <baron> |
| Component: | general | Assignee: | shenlebantongying <shenlebantongying> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | 1i5t5.duncan, shenlebantongying, ticket.kde.djr4kjpch5320z5k |
| Priority: | NOR | ||
| Version First Reported In: | 21.08.3 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/kdialog/commit/1a808ac2b8a007c6cfff777a69d04f15b99b9f4c | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | KDialog progress test script | ||
|
Description
Nicholas Redgrave
2022-02-11 15:15:15 UTC
It's like that for quite some time. I thought it was because I have scaling but I was wrong. Not sure kdialog's actually actively maintained any longer (tho it is kept building and working, including running as a native wayland binary and current qt6 porting work). For more on that see bug #455994 which I just filed: https://bugs.kde.org/show_bug.cgi?id=455994 Meanwhile, I've not had occasion to use --progressbar and wasn't aware of this bug until the pre-bug-file search for the above, but as it hasn't been mentioned yet, kdialog should now ship with a kdialog_progress_helper binary (depending on your distro packaging, of course), which I /assume/ does what its name indicates, and that it's "the modern way" to deal with kdialog progressbars. Unfortunately it's entirely undocumented AFAICT, nothing on the tutorial (which uses the bare kdialog --progressbar), nothing in the README, no manpages or kde handbook entries for kdialog at all, and it doesn't even have the --help output that kdialog itself has. And it's an elf binary so can't just open it in a text editor like a script to see what it does. So it seems it's "read the source" (if you can) or try your luck with experiments. =:^( I just hunted down the problem, and a fix is here https://invent.kde.org/utilities/kdialog/-/merge_requests/16 Just hoping someone can merge it soon. Git commit 071216ef09c80c07027bf37db216d0b90d2bfbf3 by Bharadwaj Raju, on behalf of shenleban tongying. Committed on 15/01/2023 at 08:05. Pushed by bharadwaj-raju into branch 'master'. fix: disable progressdialog's autoreset `QProgressDialog` has a default `autoreset` turned on which will reset the progress bar when max value reached and it will prevents 100% being shown The source of truth is here: https://github.com/qt/qtbase/blame/bd99d02123dcb9e406d06605fe0fa8a9d2cea3a4/src/widgets/dialogs/qprogressdialog.cpp#L655-L657 I don't know why `QProgressDialog` have `autoreset` while `QProgressBar` don't, but it is there for at least 10 years. To test this: ``` dbusRef=`kdialog --progressbar "init val" 3` qdbus $dbusRef Set "" value 1 sleep 1 qdbus $dbusRef Set "" value 2 sleep 1 qdbus $dbusRef Set "" value 3 sleep 1 ``` M +1 -0 src/progressdialog.cpp https://invent.kde.org/utilities/kdialog/commit/071216ef09c80c07027bf37db216d0b90d2bfbf3 Git commit 1a808ac2b8a007c6cfff777a69d04f15b99b9f4c by Bharadwaj Raju, on behalf of shenleban tongying. Committed on 15/01/2023 at 08:59. Pushed by bharadwaj-raju into branch 'release/22.12'. fix: disable progressdialog's autoreset `QProgressDialog` has a default `autoreset` turned on which will reset the progress bar when max value reached and it will prevents 100% being shown The source of truth is here: https://github.com/qt/qtbase/blame/bd99d02123dcb9e406d06605fe0fa8a9d2cea3a4/src/widgets/dialogs/qprogressdialog.cpp#L655-L657 I don't know why `QProgressDialog` have `autoreset` while `QProgressBar` don't, but it is there for at least 10 years. To test this: ``` dbusRef=`kdialog --progressbar "init val" 3` qdbus $dbusRef Set "" value 1 sleep 1 qdbus $dbusRef Set "" value 2 sleep 1 qdbus $dbusRef Set "" value 3 sleep 1 ``` (cherry picked from commit 071216ef09c80c07027bf37db216d0b90d2bfbf3) M +1 -0 src/progressdialog.cpp https://invent.kde.org/utilities/kdialog/commit/1a808ac2b8a007c6cfff777a69d04f15b99b9f4c |