Bug 449655

Summary:	Kdiff3 can't delete symbolic links on folder comparation
Product:	[Applications] kdiff3	Reporter:	witchhunter <witchhunterpro>
Component:	application	Assignee:	michael <reeves.87>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	witchhunterpro
Priority:	NOR
Version First Reported In:	1.9.4
Target Milestone:	---
Platform:	Manjaro
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description witchhunter 2022-02-05 15:18:30 UTC

SUMMARY

Comparing two folders, all on the same partition, one has symbolic link pointing to a file and the other doesn't.
Upon comparation choose operation "Delete (if exists)" on symbolic link. All other files with the same option get processed/deleted except symbolic link.


STEPS TO REPRODUCE
1. Copy some folder
2. Put symbolic link in copied folder pointing to some file
3. Compare two folders
4. Mark symbolic link to be deleted
5. Start folder merge

OBSERVED RESULT
Link doesn't get deleted.

EXPECTED RESULT
Link should be deleted.

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.2
Kernel Version: 5.16.2-1-MANJARO (64-bit)
Graphics Platform: X11
FS: ext4

ADDITIONAL INFORMATION
In settings > folder, "follow file/folder links" option is checked by default. I'm not sure that is the best default.

Comment 1 michael 2022-04-06 16:55:03 UTC

This issue is not reproducible in current branch or master. You must re-scan for kdiff3 to pickup the change once a file or folder is deleted. In view of the purposed patch I received via e-mail there also seems to be some confusion about the intended function. First KDiff3 by design does not modify anything but the detestation directory period. Second MergeFileInfos::fullNameDest can not simply be replaced by a function that ignores the possibly customized directory returned by gDirInfo->destDir(). In any event this works as intended in current source. Please provide the error you are recieving if this does not resolve your issue.

Comment 2 witchhunter 2022-04-07 17:26:16 UTC

(In reply to michael from comment #1)
> This issue is not reproducible in current branch or master. 
This is correct. I cannot reproduce the bug anymore in Plasma 5.24.3.
Also, Dolphin recognize the changes immediately. Excellent.

> In view of the purposed patch I received via e-mail 
DISCLAIMER: 
I am not a programmer by profession and I never send you any e-mails, nor am I familiar with any MR regarding this bug on https://invent.kde.org/sdk/kdiff3.
If you are implying someone have send you message on my behalf, please DO REPLY on this comment.
I am deeply sorry if I cause you any inconvenience.

Comment 3 michael 2022-04-07 23:51:52 UTC

No need for an apology this was a private connect by someone who like you wanted to help but didn't know kde's way of doing this. Open source is all about people having access to do just that. I would rather spend a few extra minutes triaging an issue than have something like this fall through the cracks. The message was more of an FYI for anyone else who sees this. There was no actual mr ever created in this case.