| Summary: | Application of colour-schemes whose file-identifiers are not adherent to expectation subsequently causes incorrect operation. | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Roke Julian Lockhart Beedell <4wy78uwh> |
| Component: | kcm_colors | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | jpwhiting, mwoehlke.floss, nate, nicolas.fella |
| Priority: | NOR | ||
| Version: | 5.23.90 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-integration/commit/96c85d1c0be8fc437554c1462c427bb576018e81 | Version Fixed In: | 5.24.1 |
| Sentry Crash Report: | |||
| Attachments: | Backtraces. They are identical to what is present within this notification of erroneous operation. | ||
|
Description
Roke Julian Lockhart Beedell
2022-02-04 18:23:07 UTC
This submission of notification of erroneous operation is relevant to 'http://bugs.kde.org/show_bug.cgi?id=449614' and 'http://bugs.kde.org/show_bug.cgi?id=449615'. *** Bug 449614 has been marked as a duplicate of this bug. *** *** Bug 449615 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-integration/-/merge_requests/34 > similar to '( JI-BLAK ) .COLORS' this is unsupported. color scheme files have to end in .colors (lowercase) > '( JI-BLAK ) .txt.colors' this is debatable. I can point to the place where it breaks (the usage of QFile::baseName() in https://invent.kde.org/plasma/plasma-workspace/-/blob/master/kcms/colors/colorsmodel.cpp#L174), but I'm not sure it's worth fixing. In any case it should not crash apps, which is what the MR fixes Git commit df7ed806ff4182e4c759d394509abd791e97056f by Nicolas Fella. Committed on 05/02/2022 at 17:25. Pushed by ngraham into branch 'master'. Gracefully handle invalid color scheme setting When for whatever reason ColorScheme from kdeglobals point to a nonexistant scheme then no entry for m_palettes[QPlatformTheme::SystemPalette] is created, leading to a crash down the line Instead fall back to BreezeLight to avoid a crash M +5 -2 src/platformtheme/khintssettings.cpp https://invent.kde.org/plasma/plasma-integration/commit/df7ed806ff4182e4c759d394509abd791e97056f Git commit 96c85d1c0be8fc437554c1462c427bb576018e81 by Nate Graham, on behalf of Nicolas Fella. Committed on 07/02/2022 at 17:36. Pushed by ngraham into branch 'Plasma/5.24'. Gracefully handle invalid color scheme setting When for whatever reason ColorScheme from kdeglobals point to a nonexistant scheme then no entry for m_palettes[QPlatformTheme::SystemPalette] is created, leading to a crash down the line Instead fall back to BreezeLight to avoid a crash (cherry picked from commit df7ed806ff4182e4c759d394509abd791e97056f) M +5 -2 src/platformtheme/khintssettings.cpp https://invent.kde.org/plasma/plasma-integration/commit/96c85d1c0be8fc437554c1462c427bb576018e81 |