| Summary: | «Clipboard» and «Audio Volume» applets won't close their popup when clicked on an icon in system tray | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | ratijas <me> |
| Component: | System Tray widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, justin.zobel, materka, nate, noahadvs |
| Priority: | VHI | Keywords: | regression |
| Version First Reported In: | 5.23.90 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/1fcf3553ae2ff25a8404c82e76fc3e13d36cb650 | Version Fixed In: | 5.24 |
| Sentry Crash Report: | |||
|
Description
ratijas
2022-02-03 00:23:13 UTC
Notifications and Vault also can' Oops, ignore the previous incomplete comment. I meant to say Plasma Vaults and the notification applet also can't be dismissed by clicking on their icon again. Can confirm, seems to be a regression from sometime yesterday when this was working for me. Git bisect says this was caused by the following commit: d58b9eabf3959473030c685690277d9d2f03f388 is the first bad commit commit d58b9eabf3959473030c685690277d9d2f03f388 Author: Noah Davis <noahadvs@gmail.com> Date: Mon Jan 31 09:21:50 2022 -0500 systemtray AbstractItem: Improve touch feedback Applets in PlasmoidItem were blocking events from reaching the ToolTipArea, so I moved the on hover logic to the AbstractItem's MouseArea and put the MouseArea over the iconContainer. The iconContainer is the parent of applets. Presses tend to hit the center, which is where the applet is, preventing ToolTipArea::containsMouse from being true and preventing the highlight from moving to the pressed item. Hopefully this doesn't cause duplicate actions when events reach the applet. I tested the patch on the nightcolor applet and all the other default applets and didn't see anything wrong. I think this may be because the signals are sending QML MouseEvents to the applets, causing them to be accepted if the applet can accept them. Then when the signal handlers are done, since the events are already accepted, they should not move beyond the MouseArea and cause another round of event handling. .../package/contents/ui/items/AbstractItem.qml | 24 +++++++++++++--------- 1 file changed, 14 insertions(+), 10 deletions(-) That commit made it into the stable branch which just got tarred today. Raising to VHI priority as this is a serious regression we shouldn't ship with. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1434 Git commit a321bbcefee7d221fc2fd52a569bdb8740b9dd0b by Ismael Asensio. Committed on 03/02/2022 at 20:46. Pushed by ngraham into branch 'master'. systray: Fix systray collapsing on click The MouseArea in AbstractItem needs to be above applets when it's in the grid hidden area so that it can receive hover events while the mouse is over an applet But when the applet is shown as an icon on the regular systray it needs to be below so the PlasmoidItem `onClick` takes precedence and systray collapsing works. FIXED-IN: 5.24 M +4 -3 applets/systemtray/package/contents/ui/items/AbstractItem.qml https://invent.kde.org/plasma/plasma-workspace/commit/a321bbcefee7d221fc2fd52a569bdb8740b9dd0b Git commit 1fcf3553ae2ff25a8404c82e76fc3e13d36cb650 by Nate Graham, on behalf of Ismael Asensio. Committed on 03/02/2022 at 21:35. Pushed by ngraham into branch 'Plasma/5.24'. systray: Fix systray collapsing on click The MouseArea in AbstractItem needs to be above applets when it's in the grid hidden area so that it can receive hover events while the mouse is over an applet But when the applet is shown as an icon on the regular systray it needs to be below so the PlasmoidItem `onClick` takes precedence and systray collapsing works. FIXED-IN: 5.24 (cherry picked from commit a321bbcefee7d221fc2fd52a569bdb8740b9dd0b) M +4 -3 applets/systemtray/package/contents/ui/items/AbstractItem.qml https://invent.kde.org/plasma/plasma-workspace/commit/1fcf3553ae2ff25a8404c82e76fc3e13d36cb650 Apparently, not completely fixed: desktop containment still suffers from a slightly different problem: https://bugs.kde.org/show_bug.cgi?id=449633 |