| Summary: | QML Cover Switch and Flip Switch effects has low fps | ||
|---|---|---|---|
| Product: | [Plasma] kdeplasma-addons | Reporter: | Samuel Reddy <samuelsumukhreddy> |
| Component: | Task Switchers | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, isma.af, nate, pprkut, thomas.bettler |
| Priority: | NOR | Keywords: | usability |
| Version: | 5.23.90 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=450230 | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/034e99ba0ca852a047a2b26b8fb3d373afe2ec51 | Version Fixed In: | 5.25.3 |
| Sentry Crash Report: | |||
|
Description
Samuel Reddy
2022-01-26 02:32:40 UTC
On some simple tests I've done (using the showFPS effect) it seems that the a high FPS loss (~60->30) happens when the "show highlighted window" option is enabled, which would point to that specific effect more than to the switchers themselves. Disabling this option, there's also a FPS reduction, but much less aggressive (to ~45-50 FPS on my intel integrated GPU). This happens also on other task switchers (for instance, thumbnails), although it is more noticeable for cover/flip because the reduction in FPS can make the animations lag. I wonder if, as a mitigation, the effect could be optionally disabled for fullscreen switchers, even if the user marks the option. I'll wait for confirmation of this before moving this to kwin/effects-various I can confirm that. Disabling "Show selected window" for fullscreen task switchers makes sense to me, since otherwise KWin is doing extra work that just gets thrown away, impacting performance. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2603 Git commit 3c5c079aa58b8c0cdf8ae2bf9fa8f01d2c53407f by Ismael Asensio. Committed on 03/07/2022 at 16:51. Pushed by iasensio into branch 'master'. TabBox: Do not highlight selected window for fullscreen switchers This helps improving performance on those effects, where the highlighted window is not even shown. FIXED-IN: 5.25.3 M +15 -4 src/tabbox/tabboxhandler.cpp https://invent.kde.org/plasma/kwin/commit/3c5c079aa58b8c0cdf8ae2bf9fa8f01d2c53407f Git commit 034e99ba0ca852a047a2b26b8fb3d373afe2ec51 by Ismael Asensio. Committed on 03/07/2022 at 18:10. Pushed by iasensio into branch 'Plasma/5.25'. TabBox: Do not highlight selected window for fullscreen switchers This helps improving performance on those effects, where the highlighted window is not even shown. FIXED-IN: 5.25.3 (cherry picked from commit 3c5c079aa58b8c0cdf8ae2bf9fa8f01d2c53407f) M +15 -4 src/tabbox/tabboxhandler.cpp https://invent.kde.org/plasma/kwin/commit/034e99ba0ca852a047a2b26b8fb3d373afe2ec51 The animation is still laggy for both task switchers on my system after update to Plasma 5.25.3. Operating System: Arch Linux KDE Plasma Version: 5.25.3 KDE Frameworks Version: 5.96.0 Qt Version: 5.15.5 Graphics Platform: Wayland |