Bug 449179

Summary:	Visual bugs during zoom animation
Product:	[Applications] dolphin	Reporter:	popov895 <popov895>
Component:	view-engine: general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kfm-devel, nate, popov895
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/system/dolphin/commit/82509612067bd39355372d8dc2ceed932f91d130	Version Fixed In:	22.04
Attachments:	Icons view Compact view Yet another video. Resetting zoom from huge to smallest. Yet another bug when renaming a file/folder

Description popov895 2022-01-25 21:42:09 UTC

SUMMARY

Under some conditions, zooming animation leads to annoying visual bugs. Please, see attachments for details..

SOFTWARE/OS VERSIONS

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.24.80
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3
Graphics Platform: X11

Comment 1 popov895 2022-01-25 21:45:56 UTC

Created attachment 145938 [details]
Icons view

Icons view, minimum zoom level. Zooming in and out causes some icons to "jump".

Comment 2 popov895 2022-01-25 21:51:08 UTC

Created attachment 145939 [details]
Compact view

Compact view, minimum zoom level. Zooming in and out causes the labels to be cut off during animation.

Comment 3 popov895 2022-01-27 08:29:54 UTC

It may be worth disabling the zoom animation.

Comment 4 popov895 2022-01-29 10:24:42 UTC

Created attachment 146028 [details]
Yet another video. Resetting zoom from huge to smallest.

Comment 5 Bug Janitor Service 2022-02-01 13:05:48 UTC

A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/338

Comment 6 Felix Ernst 2022-02-13 12:16:38 UTC

Git commit a05343530d0f43434715888902067512309098ce by Felix Ernst, on behalf of Eugene Popov.
Committed on 13/02/2022 at 12:16.
Pushed by felixernst into branch 'master'.

Fix zooming animation

Current implementation of the zooming animation is a bit buggy.
This MR fixes the following issues:
* in the Icon view mode, the icons sometimes "jump"
* in the Compact view mode, the labels sometimes are cut off

M  +11   -12   src/kitemviews/kitemlistview.cpp
M  +27   -2    src/kitemviews/kitemlistwidget.cpp
M  +11   -0    src/kitemviews/kitemlistwidget.h
M  +23   -21   src/kitemviews/kstandarditemlistwidget.cpp
M  +1    -0    src/kitemviews/kstandarditemlistwidget.h
M  +8    -0    src/kitemviews/private/kitemlistviewanimation.cpp
M  +3    -3    src/kitemviews/private/kitemlistviewanimation.h

https://invent.kde.org/system/dolphin/commit/a05343530d0f43434715888902067512309098ce

Comment 7 popov895 2022-02-23 13:00:33 UTC

Created attachment 147073 [details]
Yet another bug when renaming a file/folder

Comment 8 popov895 2022-02-23 15:14:47 UTC

Reopened since Comment 7.

Comment 9 Ismael Asensio 2022-02-25 19:37:06 UTC

Git commit 82509612067bd39355372d8dc2ceed932f91d130 by Ismael Asensio, on behalf of Eugene Popov.
Committed on 25/02/2022 at 19:37.
Pushed by iasensio into branch 'master'.

[CompactView] Remove animation on file rename

This MR fixes an issue where the label is cut off when renaming in Compact View mode.
FIXED-IN: 22.04

M  +2    -20   src/kitemviews/kitemlistview.cpp
M  +0    -2    src/kitemviews/kitemlistview.h

https://invent.kde.org/system/dolphin/commit/82509612067bd39355372d8dc2ceed932f91d130