Bug 449129

Summary:	System settings for boot splash not sets anything
Product:	[Applications] systemsettings	Reporter:	Jacek Rzęsista <jasio>
Component:	kcm_plymouth	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	nate, okellogg
Priority:	NOR
Version First Reported In:	5.23.5
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Jacek Rzęsista 2022-01-25 11:32:51 UTC

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
System settings for bootsplash not working at all. Whatever I set, I always see default KDE Neon bootsplash screen.

STEPS TO REPRODUCE
1. Run: System settings -> Appearance -> Boot Splash Screen
2. Change to whatever splash you want, you can download any new splash and change to it
3. Apply settings

OBSERVED RESULT
After reboot you can still see default KDE Neon bootsplash screen.

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: -
macOS: -
Linux/KDE Plasma: KDE Neon 5.23 User Edition
(available in About System)
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2022-01-25 21:17:33 UTC

Seems like the same issue as Bug 449130.

*** This bug has been marked as a duplicate of bug 449130 ***

Comment 2 Oliver Kellogg 2022-01-30 21:27:57 UTC

Git commit 9acd3b8418f9c1b5e77b4294ddebbe64757720c9 by Oliver Kellogg.
Committed on 30/01/2022 at 21:27.
Pushed by okellogg into branch 'master'.

Fix crash importing Pascal code via import wizard:

umbrello/umldoc.{h,cpp}
- New function findDatatype(QString name, bool includeInactive) seeks
  the given name in the Datatypes folder and returns pointer to the
  UMLDatatype object if found, otherwise nullptr.
- In function createDatatype return pointer to the UMLDatatype created.

umbrello/codeimport/pascalimport.h
- Prepare for reimplementing NativeImportBase function `split'.

umbrello/codeimport/pascalimport.cpp
- Add TODO note at function split(const QString&).
- In function parseStmt :
  - Log a debug message showing the token currently being parsed along
    with its m_srcIndex and following token.
  - Add preliminary handling of "[".
  - On handling "function", "procedure", "constructor", "destructor",
    if m_klass is null then call skipStmt() before returning.
  - At start of handling m_section sect_TYPE, if m_klass is null then
    save return value from advance() to local QString rhsName for
    preserving the casing (which is lost in `keyword').
  - Provide first implementation for handling datatypes.
  - On handling "At this point we need a class [...]" near end of
    function,
    - handle nullptr returned by Import_Utils::insertAttribute as a
      regular error and avoid dereferencing it;
    - handle nullptr returned by o->asUMLAttribute() as a regular error
      and avoid dereferencing it.
    This hunk is the actual crash fix.
FIXED-IN:2.33.80 (KDE releases 22.03.80)

M  +62   -6    umbrello/codeimport/pascalimport.cpp
M  +2    -0    umbrello/codeimport/pascalimport.h
M  +28   -2    umbrello/umldoc.cpp
M  +2    -1    umbrello/umldoc.h

https://invent.kde.org/sdk/umbrello/commit/9acd3b8418f9c1b5e77b4294ddebbe64757720c9

Comment 3 Oliver Kellogg 2022-01-30 21:30:39 UTC

Oh, sorry for the noise. I mistyped the bug number on my commit :/
It should have been bug 449219.

Comment 4 Nate Graham 2022-01-30 22:05:17 UTC


*** This bug has been marked as a duplicate of bug 449130 ***