Bug 449124

Summary:	"Light Theme / Dark Theme" setting switches only between "Breath Light / Breath Dark"
Product:	[Applications] systemsettings	Reporter:	Michele Perrone <perrone.michele>
Component:	Quick Settings	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED DOWNSTREAM
Severity:	normal	CC:	nate
Priority:	NOR
Version First Reported In:	5.23.5
Target Milestone:	---
Platform:	Manjaro
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Michele Perrone 2022-01-25 10:14:56 UTC

SUMMARY
In "Quick Settings", there is an option to switch between "Light Theme" and "Dark Theme". On my system, there is no way to set these themes other than "Breath Light" and "Breath Dark": applying "Light Theme" selects always "Breath Light" and applying "Dark Theme" selects always "Breath Dark".
There should be an option to set the default Light/Dark Theme.

This also causes problems with GTK apps. I have set the GTK theme to "Breeze", which has both a Light and Dark variant. However, if "Quick Settings" switches only between "Breath Light" and "Breath Dark", then GTK apps do not toggle between the Light/Dark variant of "Breeze".

I think that the solution could be:
1. Allowing to set the default PLASMA "Light Theme" and "Dark Theme" for "Quick Settings"
2a. Allowing to set the default GTK "Light Theme" and "Dark Theme" for "Quick Settings", OR
2b. Toggle between the light/dark variant of the currently selected GTK theme

STEPS TO REPRODUCE
1. Open "System Settings -> Appearance -> Global Theme"
2. Select any theme except for "Breath Light" or "Breath Dark"
3. Open "System Settings -> Quick Settings"
4. Toggle "Light Theme" or "Dark Theme"

OBSERVED RESULT
"Light Theme" default always to "Breath Light", "Dark Theme" defaults always to "Breath Dark". Furthermore, the GTK theme is not toggled between its Light/Dark version

EXPECTED RESULT
The user should be able to choose the default "Light Theme" and "Dark Theme" which is applied in "Quick Settings". This choice should also be made available for the GTK theme. The "Light/Dark Theme" selection should also toggle between the GTK theme light/dark variants.

SOFTWARE/OS VERSIONS
Linux: 5.16.2-1-MANJARO
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.2
Graphics Platform: X11

Comment 1 Nate Graham 2022-01-25 21:22:49 UTC

These quick settings toggles are designed to be just that: quick settings between the two most common themes you might want to use.

Evidently Manjaro is packing the KCM to make them toggle between Breath versions rather than Breeze version, which is does by default. That would be something to talk to the Manjaro people about.

The GTK issue is Bug 448044.

Comment 2 Michele Perrone 2022-01-25 22:06:06 UTC

Hi Nate, and thank you for your reply.

(In reply to Nate Graham from comment #1)
> Evidently Manjaro is packing the KCM to make them toggle between Breath
> versions rather than Breeze version, which is does by default. That would be
> something to talk to the Manjaro people about.

You are right.

(In reply to Nate Graham from comment #1)
> The GTK issue is Bug 448044.

Thanks, I'll keep an eye on that issue.

(In reply to Nate Graham from comment #1)
> These quick settings toggles are designed to be just that: quick settings
> between the two most common themes you might want to use.

I agree on the fact that the quick settings should remain quick. However, I still think that the light/dark theme in quick settings shouldn't be something hardcoded.
Different users may want to switch between the light/dark variant of different themes, without going to the "Global Theme" menu every time.
What do you think?

Comment 3 Michele Perrone 2022-01-25 22:16:32 UTC

And there is another thing. If I do, for example, the following: 
1. Choose the Light theme from Quick Settings
2. Change something like Window Decorations or Cursors from Appearance->Global Theme
3. Toggle to Dark theme and then back to Light theme,
I see that neither the Window Decorations I had previously selected nor Cursors are preserved. They are restored to their defaults.
Is this intended? It doesn't strike as very intuitive since some other settings (e.g. Titlebar Buttons arrangement) are not nuked.