Summary: | Places panel is too wide | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Fabian Vogt <fabian> |
Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kfm-devel, postix, qydwhotmail, variable_valuables761 |
Priority: | NOR | ||
Version First Reported In: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/system/dolphin/-/commit/7eb1696a32891ce4f1f0e44c590a7fdb7c55fecd | Version Fixed In: | |
Sentry Crash Report: |
Description
Fabian Vogt
2022-01-24 11:26:33 UTC
I looked into this a few months ago (since it's long been the only failing test in openQA for Tumbleweed KDE) and forgot to report back. Seems like it might have been a side effect of this major overhaul? https://invent.kde.org/system/dolphin/-/merge_requests/309 I think it's been so long that this new larger width has basically become the de facto default and expected behavior. I still think the current width is too wide subjectively though, so I'd still suggest we narrow it, even if it'd perhaps now be considered a wishlist item rather than a regression fix. In any case, I think the openQA test will need adjusting as it's effectively become outdated now. > I looked into this a few months ago (since it's long been the only failing test in openQA for Tumbleweed KDE) and forgot to report back. It's just a softfail, i.e. "not great but ok for now". It's possible to just remove the bug reference though and it'll turn green instead of orange. > I think it's been so long that this new larger width has basically become the de facto default and expected behavior. I still think the current width is too wide subjectively though, so I'd still suggest we narrow it, even if it'd perhaps now be considered a wishlist item rather than a regression fix. +1 on both. Opened https://invent.kde.org/system/dolphin/-/merge_requests/1016 (bug janitor bot didn't auto-link it here?) A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/1059 Git commit 7eb1696a32891ce4f1f0e44c590a7fdb7c55fecd by Méven Car, on behalf of Tem PQD. Committed on 26/09/2025 at 09:12. Pushed by meven into branch 'master'. placespanel: Fix default width by moving things from showEvent to constructor Move instantiation, setModel, and some connections to constructor and remove showEvent. This was being done in an erroneous lazy order which led to the places panel's sizeHint not being called properly. Also removes the double loading workaround in setUrl, which is no longer needed either. M +16 -27 src/panels/places/placespanel.cpp M +0 -2 src/panels/places/placespanel.h https://invent.kde.org/system/dolphin/-/commit/7eb1696a32891ce4f1f0e44c590a7fdb7c55fecd |