Bug 449004

Summary: Panel context menu item does not change to say "Exit Edit Mode" when already in edit mode
Product: [Plasma] plasmashell Reporter: wojnilowicz <lukasz.wojnilowicz>
Component: PanelAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: nate, plasma-bugs-null, postix
Priority: NOR    
Version First Reported In: 5.23.90   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/frameworks/plasma-framework/-/commit/90a537ee1dec324acd241e55548e58334f977892 Version Fixed/Implemented In: 6.0
Sentry Crash Report:
Attachments: Enter Edit Mode

Description wojnilowicz 2022-01-23 11:14:35 UTC 
Created attachment 145794 [details]
Enter Edit Mode

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1.  RMB on a desktop area
2. Click on "Enter Edit Mode"
3. RMB on a desktop area

OBSERVED RESULT
Enter Edit Mode

EXPECTED RESULT
Exit Edit Mode


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Seen on neon-unstable-20220116-0330.iso
Comment 1 Nate Graham 2022-01-23 22:04:15 UTC 
Yeah looks like the context menu item for the panel doesn't update its text properly. The one on the desktop one does, though.
Comment 2 Nate Graham 2023-04-24 18:36:45 UTC 
*** Bug 468803 has been marked as a duplicate of this bug. ***
Comment 3 postix 2023-04-24 19:00:22 UTC 
(In reply to Nate Graham from comment #1)
> Yeah looks like the context menu item for the panel doesn't update its text
> properly. The one on the desktop one does, though.

It doesn't only update its text not properly but also doesn't exit the mode.
Comment 4 Bug Janitor Service 2023-09-19 21:07:12 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/885
Comment 5 Nate Graham 2023-09-21 14:47:35 UTC 
Git commit 90a537ee1dec324acd241e55548e58334f977892 by Nate Graham.
Committed on 21/09/2023 at 16:46.
Pushed by ngraham into branch 'master'.

containment: Make menu text say "Exit Edit Mode" when already in Edit Mode
FIXED-IN: 6.0

M  +9    -0    src/plasma/containment.cpp

https://invent.kde.org/frameworks/plasma-framework/-/commit/90a537ee1dec324acd241e55548e58334f977892