| Summary: | Renaming sensors in a grid display style does not rename the actual objects in the row in System Monitor | ||
|---|---|---|---|
| Product: | [Applications] plasma-systemmonitor | Reporter: | Tarczal Dániel János <tarczaldj> |
| Component: | general | Assignee: | KSysGuard Developers <ksysguard-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | ahiemstra, lemmyg, nate, plasma-bugs, stefan.lux |
| Priority: | NOR | ||
| Version: | 5.23.5 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/libksysguard/commit/88075dc213a55de359bd783be8a17aef5a334ae0 | Version Fixed In: | 5.24 |
| Sentry Crash Report: | |||
| Attachments: |
Picture of the bug
row title renaming example |
||
|
Description
Tarczal Dániel János
2022-01-22 21:52:52 UTC
Hello, I try the reproduce the issue. When you say " in their default in the row", are you saying that for example CPU all > Total Usage would stay as Total usage even we rename it? I manage to reproduce some renaming issue only with widgets in the main panel. Widgets created in the Systems Monitor or directly in the desktop are following correctly the title field. When you say "the title stay with whatever sensor the default name" you mean that doesn't follow the title field and stays with the sensor default name for example in CPU all, "Total Usage" Is this the issue you are referring to? My system is: Kubuntu 21.10 Plasma 5.23.5 frameworks: 5.90.0 Regards, Galder Created attachment 145861 [details]
Picture of the bug
Hello,
I attached a picture of this that might help visualize this more.
I don't really know what you are refering to as "main panel", in System Monitor I created a new page, added a row, and changed the display style to grid. Also, I created a desktop widget from the same row, and there it displays correctly.
For the title, I meant the title of my bug report, sorry if I wasn't clear.
Regards,
Dani
Created attachment 145877 [details]
row title renaming example
Hello, with "main panel" I was referring to the desktop panel. Sorry for the confusion, I'm a newbie triaging issues. I'm bite confuse. I have attached a screenshot with a new page in the system Settings. You can only change the name of the title of the row(in the top). I don't think can you rename the actual sensors names. If you are looking for renaming the actual sensors, that would a feature request. Please let me know if this is what you are looking for. Thanks Galder Renaming sensors has been added for 5.23. I can confirm this bug, apparently I forgot to add support for renaming when I created this face. Perfect! A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/208 Git commit a1ec6b8dc3db8f8b4b1cf9137a41ccc9a471888d by Arjen Hiemstra. Committed on 01/02/2022 at 15:24. Pushed by ahiemstra into branch 'master'. Support changing sensor label names for the Grid face This was apparently forgotten when creating the face in the first place. M +20 -0 faces/FaceLoader.cpp M +10 -0 faces/FaceLoader.h M +2 -0 faces/facepackages/facegrid/contents/ui/FaceControl.qml https://invent.kde.org/plasma/libksysguard/commit/a1ec6b8dc3db8f8b4b1cf9137a41ccc9a471888d Git commit 88075dc213a55de359bd783be8a17aef5a334ae0 by Arjen Hiemstra. Committed on 01/02/2022 at 16:10. Pushed by ahiemstra into branch 'Plasma/5.24'. Support changing sensor label names for the Grid face This was apparently forgotten when creating the face in the first place. (cherry picked from commit a1ec6b8dc3db8f8b4b1cf9137a41ccc9a471888d) M +20 -0 faces/FaceLoader.cpp M +10 -0 faces/FaceLoader.h M +2 -0 faces/facepackages/facegrid/contents/ui/FaceControl.qml https://invent.kde.org/plasma/libksysguard/commit/88075dc213a55de359bd783be8a17aef5a334ae0 *** Bug 447846 has been marked as a duplicate of this bug. *** |