| Summary: | kwin_wayland crashed in KWin::Xwl::WlSource::checkStartTransfer() when I tried to drag a screenshot from Spectacle to Discord | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Patrick Silva <bugseforuns> |
| Component: | wayland-generic | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | nate |
| Priority: | NOR | Keywords: | wayland |
| Version: | master | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/5079fa82360a012aa48687717d7e4be8d29e0b0f | Version Fixed In: | 5.24 |
|
Description
Patrick Silva
2022-01-21 19:20:46 UTC
Works for me FWIW. So it's not a 100% reproducible thing. It looks like WlSource::m_dsi gets deleted while dnd is active. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1936 Git commit fdea6d151ec31d80047eaf9bc1649394e5e9602a by Nate Graham, on behalf of David Edmundson. Committed on 24/01/2022 at 20:43. Pushed by ngraham into branch 'master'. Fix xwayland DND crash Drag and drop objects slightly outlive wayland's DND concept as we have to cancel the client and wait for a response. This normally is fine, except in the case that the drag ended because the sender quit. Calling setWlSource on drag ends creates a matching pair with Dnd::startDrag where we first set the source and has parralels with clipboard. Selection::handleSelectionRequest checks for the presence of a source. I could not reproduce the original bug. M +1 -0 src/xwl/dnd.cpp https://invent.kde.org/plasma/kwin/commit/fdea6d151ec31d80047eaf9bc1649394e5e9602a Git commit 5079fa82360a012aa48687717d7e4be8d29e0b0f by Nate Graham, on behalf of David Edmundson. Committed on 24/01/2022 at 21:27. Pushed by ngraham into branch 'Plasma/5.24'. Fix xwayland DND crash Drag and drop objects slightly outlive wayland's DND concept as we have to cancel the client and wait for a response. This normally is fine, except in the case that the drag ended because the sender quit. Calling setWlSource on drag ends creates a matching pair with Dnd::startDrag where we first set the source and has parralels with clipboard. Selection::handleSelectionRequest checks for the presence of a source. I could not reproduce the original bug. (cherry picked from commit fdea6d151ec31d80047eaf9bc1649394e5e9602a) M +1 -0 src/xwl/dnd.cpp https://invent.kde.org/plasma/kwin/commit/5079fa82360a012aa48687717d7e4be8d29e0b0f |