Bug 448793

Summary: Tag shortcuts behavior not consistent when multiple photos are selected with some already containing tag
Product: [Applications] digikam Reporter: José Oliver-Didier <jose_oliver>
Component: Tags-EngineAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: caulier.gilles
Priority: NOR    
Version First Reported In: 7.5.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/graphics/digikam/commit/37e08dc3103c07d91e813d070b20177dd753d7a6 Version Fixed/Implemented In: 7.6.0
Sentry Crash Report:

Description José Oliver-Didier 2022-01-19 20:42:19 UTC 
SUMMARY
Selecting multiple photos with tag and clicking on shortcut not consistent when some of the photos have already tag present and other do not.

STEPS TO REPRODUCE
1. Assign a shortcut to a tag - In Tag Manager, select any tag and assign a shortcut for example <Ctrl>+<7>.
2. In thumbnail view, multiple select 3 photos - Photos A, B and C and add tag by press shortcut <Ctrl>+<7> - tag is added to A, B and C.
3. Select 1 of the 3 photos - Photos B press shortcut - tag is removed from photo B.
4. Select the 3 photos again - A, B and C and press shortcut.

OBSERVED RESULT
- Tag is removed from photos A and C and added to B.

EXPECTED RESULT
- Similar "3 state" behavior to star ratings shortcut and tag panel in which on first press of shortcut the tag is added only to B, pressing  a second time removes tag to A, B, C and pressing shortcut a third time adds tag to A, B and C.
- Only if all the tags in the selection are in the same state (have or do not have the tag) should the operation be add or remove all tags upon clicking the shortcut key.

SOFTWARE/OS VERSIONS
Windows 11
Comment 1 caulier.gilles 2022-01-20 10:19:21 UTC 
The behavior is the same if you assign the tag from the right sidebar instead to use the keyboard shortcut ? Typically, yes, as it's the same engine working in background, just the call to the engine differ.

Gilles Caulier
Comment 2 José Oliver-Didier 2022-01-20 11:04:22 UTC 
Not exactly. Compare with adding star ratings and color labels with shortcuts.

Select 2 photos with a star rating of "2 stars", while maintaining the selection to the first two photos, select another photo with no star rating. Click on <Ctrl>+<2> will add the 2 star rating to the third photo. Pressing the shortcut again will remote the star rating to all 3 photos. Same behavior is observed for color labels.

In tags however, if you have 2 out of 3 photos selected, and press on the assigned shortcut key - the tag assignments gets inverted (removed from the 2 existing and assigned to 1). 

When selecting the images where (2 out of 3 contain a particular tag), an empty checkbox square appears next to that particular tag indicating that "some" images have that tag assigned.  Clicking on the checkbox square assigns the tag to all selected images. Unclicking the checkbox square removes the tag assignment.

I am running Windows 11.
Comment 3 Maik Qualmann 2022-01-20 18:14:42 UTC 
Git commit 37e08dc3103c07d91e813d070b20177dd753d7a6 by Maik Qualmann.
Committed on 20/01/2022 at 18:12.
Pushed by mqualmann into branch 'master'.

change tag toggle behavior over key shortcut and multi selection
FIXED-IN: 7.6.0

M  +1    -1    NEWS
M  +5    -0    core/app/views/stack/itemiconview_tags.cpp

https://invent.kde.org/graphics/digikam/commit/37e08dc3103c07d91e813d070b20177dd753d7a6