Bug 448749

Summary:	After install new Window decoration grid view is not updated
Product:	[Applications] systemsettings	Reporter:	Piotr Mierzwinski <piotr.mierzwinski>
Component:	kcm_kwindecoration	Assignee:	Alexander Lohnau <alexander.lohnau>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alexander.lohnau, nate, nicolas.fella, plasma-bugs
Priority:	NOR
Version:	5.23.90
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/knewstuff/-/commit/d41820746bd9ee7ac0de32400c4a9c6af5194475	Version Fixed In:	5.24

Description Piotr Mierzwinski 2022-01-19 00:50:10 UTC

SUMMARY
I installed new Window Decoration by "Get New Window Decoration" (Wilow Dark and another), clicked "Close" and noticed that grid view has not been updated with newly installed decorations. Only when I clicked other option in left side bar for example "Color", and back to "Window Decoration" then found updated grid view.


STEPS TO REPRODUCE
1. open settings -> Window Decoration
2.  install any by clicking "Get New Window Decoration" button
3. "Get New Window Decoration"
4. Check grid view

OBSERVED RESULT
missing installed Window Decoration

EXPECTED RESULT
newly installed Window Decoration should be visible in grid view just after clicking Close in "Get Window Decoration" window

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
KDE Plasma Version: 5.24.80
KDE Frameworks Version: 5.91
Qt Version: 5.15.3

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2022-01-20 22:26:18 UTC

Can confirm, the grid view does not update when adding or removing window decorations.

Comment 2 Bug Janitor Service 2022-01-21 10:01:04 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1920

Comment 3 Alexander Lohnau 2022-01-21 13:07:18 UTC

Git commit 32785ec1f343e2d4ca82881f6b2defafa93aa755 by Alexander Lohnau.
Committed on 21/01/2022 at 13:06.
Pushed by alex into branch 'master'.

KWin decorations: Fix KCM not refreshing after clicking "Use"-button in KNS dialog

M  +2    -0    src/kcmkwin/kwindecoration/package/contents/ui/main.qml

https://invent.kde.org/plasma/kwin/commit/32785ec1f343e2d4ca82881f6b2defafa93aa755

Comment 4 Nate Graham 2022-01-21 18:13:47 UTC

That seems to fully fix it!

Comment 5 Alexander Lohnau 2022-01-21 18:18:51 UTC

Git commit 358c38708f23c0779dd03c2743fc7e84d550e93e by Alexander Lohnau.
Committed on 21/01/2022 at 18:18.
Pushed by alex into branch 'Plasma/5.24'.

KWin decorations: Fix KCM not refreshing after clicking "Use"-button in KNS dialog


(cherry picked from commit 32785ec1f343e2d4ca82881f6b2defafa93aa755)

M  +2    -0    src/kcmkwin/kwindecoration/package/contents/ui/main.qml

https://invent.kde.org/plasma/kwin/commit/358c38708f23c0779dd03c2743fc7e84d550e93e