Bug 448744

Created attachment 145634 [details]
attachment-25469-0.html

I don’t have a Mac to test, Kurt :(
The signal is connected.

Le mar. 18 janv. 2022 à 22:38, Kurt Hindenburg <bugzilla_noreply@kde.org> a
écrit :

> https://bugs.kde.org/show_bug.cgi?id=448744
>
>             Bug ID: 448744
>            Summary: SSHManager plugin often doesn't handle double-clicks
>                     on server names on macOS
>            Product: konsole
>            Version: master
>           Platform: Other
>                 OS: macOS
>             Status: REPORTED
>           Severity: normal
>           Priority: NOR
>          Component: general
>           Assignee: konsole-devel@kde.org
>           Reporter: kurt.hindenburg@gmail.com
>   Target Milestone: ---
>
> When double-clicking on server name in sshmanager plugin, it rarely works
> under
> macOS.  I can't figure out how to get it to work constantly.  It seems
> like the
> connectRequested signal is not connected.
>
> I haven't had any issues on any other OS - freebsd works as expected.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.

(In reply to tcanabrava from comment #1)
> Created attachment 145634 [details]
> attachment-25469-0.html
> 
> I don’t have a Mac to test, Kurt :(
> The signal is connected.
> 
> Le mar. 18 janv. 2022 à 22:38, Kurt Hindenburg <bugzilla_noreply@kde.org> a
> écrit :
> 
> > https://bugs.kde.org/show_bug.cgi?id=448744
> >
> >             Bug ID: 448744
> >            Summary: SSHManager plugin often doesn't handle double-clicks
> >                     on server names on macOS
> >            Product: konsole
> >            Version: master
> >           Platform: Other
> >                 OS: macOS
> >             Status: REPORTED
> >           Severity: normal
> >           Priority: NOR
> >          Component: general
> >           Assignee: konsole-devel@kde.org
> >           Reporter: kurt.hindenburg@gmail.com
> >   Target Milestone: ---
> >
> > When double-clicking on server name in sshmanager plugin, it rarely works
> > under
> > macOS.  I can't figure out how to get it to work constantly.  It seems
> > like the
> > connectRequested signal is not connected.
> >
> > I haven't had any issues on any other OS - freebsd works as expected.


I put print statements in connectRequested() and they are not printed.  Do you have any suggestions on what I can look at?

Created attachment 145636 [details]
attachment-27312-0.html

I don't see how this can be wrong, but let's see, on the file
src/plugins/SSHManager/sshmanagerpluginwidget.cpp I connect the treeview to
the connectRequested

connect(ui->treeView, &QTreeView::doubleClicked, this,
&SSHManagerTreeWidget::connectRequested);

The only way that this can go wrong is if Qt is not delivering correctly
the doubleClicked.

so we can try to rewrite this as:

connect(ui->treeView, &QTreeView::doubleClicked, this, [this] { qDebug() <<
"Bleh"; connectRequested()});

Because I'm connecting directly the doubleClicked to the connectRequested,
I don't see a way that this could fail.


On Tue, Jan 18, 2022 at 10:45 PM Kurt Hindenburg <bugzilla_noreply@kde.org>
wrote:
>
> https://bugs.kde.org/show_bug.cgi?id=448744
>
> --- Comment #2 from Kurt Hindenburg <kurt.hindenburg@gmail.com> ---
> (In reply to tcanabrava from comment #1)
> > Created attachment 145634 [details]
> > attachment-25469-0.html
> >
> > I don’t have a Mac to test, Kurt :(
> > The signal is connected.
> >
> > Le mar. 18 janv. 2022 à 22:38, Kurt Hindenburg <bugzilla_noreply@kde.org>
a
> > écrit :
> >
> > > https://bugs.kde.org/show_bug.cgi?id=448744
> > >
> > >             Bug ID: 448744
> > >            Summary: SSHManager plugin often doesn't handle
double-clicks
> > >                     on server names on macOS
> > >            Product: konsole
> > >            Version: master
> > >           Platform: Other
> > >                 OS: macOS
> > >             Status: REPORTED
> > >           Severity: normal
> > >           Priority: NOR
> > >          Component: general
> > >           Assignee: konsole-devel@kde.org
> > >           Reporter: kurt.hindenburg@gmail.com
> > >   Target Milestone: ---
> > >
> > > When double-clicking on server name in sshmanager plugin, it rarely
works
> > > under
> > > macOS.  I can't figure out how to get it to work constantly.  It seems
> > > like the
> > > connectRequested signal is not connected.
> > >
> > > I haven't had any issues on any other OS - freebsd works as expected.
>
>
> I put print statements in connectRequested() and they are not printed.
Do you
> have any suggestions on what I can look at?
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.

It seems it is not registering the double-click.  I notice some are using QTreeView and other connects using SshTreeView

&QTreeView::doubleClicked,
SshTreeView::mouseButtonClicked

This isn't a big issue as I doubt this effects many other people ; when I have time I'll try to figure it out.

(In reply to Kurt Hindenburg from comment #4)
> It seems it is not registering the double-click.  I notice some are using
> QTreeView and other connects using SshTreeView
> 
> &QTreeView::doubleClicked,
> SshTreeView::mouseButtonClicked
> 
> This isn't a big issue as I doubt this effects many other people ; when I
> have time I'll try to figure it out.

This shouldn't break anything as the connections are resolved in compile time, weird.

I see this one linux although much less often.  Putting some chars in the search box often allow double-clicking to work.

(In reply to Kurt Hindenburg from comment #6)
> I see this one linux although much less often.  Putting some chars in the
> search box often allow double-clicking to work.

I am also having this problem with Manjaro Linux. It is reproducable:

I double-click on a profile name and the session opens. Entering Ctrl-D closes it again.

For me, repeating above actions works multiple times, maybe six or ten times, which differs. At some time double-clicking won't work any more.

Fortunately I found this workaround from Kurt Hindenburg. Before, I had to completely close Konsole (with all my open sessions) to make double-click work again.

I just found out some information which might help:

Double-clicking in the "wrong way", i.e. first click too far away from the second click, results in following double-clicks not being recognized any more.