Summary: | timezone information being lost when copying or moving events | ||
---|---|---|---|
Product: | [Applications] korganizer | Reporter: | MAG4 <retecomputer> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 5.18.1 | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/pim/kcalutils/-/commit/ddbad7221ee1c7736212887d1d64142d6d174000 | Version Fixed In: | 5.24.1 |
Sentry Crash Report: |
Description
MAG4
2022-01-18 11:24:46 UTC
Thanks to https://bugs.kde.org/show_bug.cgi?id=448846 we investigate further and we find that also moving events directly on calendar views makes timezone information being lost. Timezone information are correctly saved only if you use Event dialog as https://bugs.kde.org/attachment.cgi?id=145781 (useful as a temporary workaround). Greetings! Guido A possibly relevant merge request was started @ https://invent.kde.org/pim/kcalutils/-/merge_requests/29 A possibly relevant merge request was started @ https://invent.kde.org/pim/eventviews/-/merge_requests/89 Git commit ddbad7221ee1c7736212887d1d64142d6d174000 by Daniel Vrátil. Committed on 23/08/2023 at 16:56. Pushed by dvratil into branch 'release/23.08'. Preserve timezone of original incidence when copy-pasting The destination date-time provided by the caller will likely be in local time, but could theoretically be in any arbitrary timezone. Since we are creating a *copy* it makes sense to preserve the timezone of the original dtStart/dtEnd/dtDue in the incidence. FIXED-IN: 5.24.1 M +20 -5 src/dndfactory.cpp https://invent.kde.org/pim/kcalutils/-/commit/ddbad7221ee1c7736212887d1d64142d6d174000 Git commit def2b7f4cc507bcf8f64540e77dd736ebb751e7d by Daniel Vrátil. Committed on 23/08/2023 at 16:55. Pushed by dvratil into branch 'release/23.08'. Agenda: fix timezone being lost when moving event by drag The code was using QDateTime::toTimeSpec() in attempt to restore the timezone from the original dtStart/dtEnd. However, QDateTime::toTimeSpec() automatically converts Qt::TimeZone timespec to Qt::LocalTime, so the information about timezone was lost and the time was treated as local. The solution is to restore the timezone manually when the original timespec was Qt::TimeZone. FIXED-IN: 5.24.1 M +22 -4 src/agenda/agendaview.cpp https://invent.kde.org/pim/eventviews/-/commit/def2b7f4cc507bcf8f64540e77dd736ebb751e7d Git commit 916130a1c168c6e36a960c6c706a650b949cc0cc by Daniel Vrátil. Committed on 11/01/2024 at 10:04. Pushed by dvratil into branch 'master'. Agenda: fix timezone being lost when moving event by drag The code was using QDateTime::toTimeSpec() in attempt to restore the timezone from the original dtStart/dtEnd. However, QDateTime::toTimeSpec() automatically converts Qt::TimeZone timespec to Qt::LocalTime, so the information about timezone was lost and the time was treated as local. The solution is to restore the timezone manually when the original timespec was Qt::TimeZone. FIXED-IN: 5.24.1 (cherry picked from commit def2b7f4cc507bcf8f64540e77dd736ebb751e7d) M +22 -4 src/agenda/agendaview.cpp https://invent.kde.org/pim/eventviews/-/commit/916130a1c168c6e36a960c6c706a650b949cc0cc |