Bug 448680

Summary:	REGRESSION: no webrunners show up anymore
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	Thiago Sueto <herzenschein>
Component:	general	Assignee:	KIO Bugs <kio-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alexander.lohnau, kdelibs-bugs, nate
Priority:	VHI	Keywords:	regression
Version:	git master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/kconfigwidgets/commit/765ab0f3b28b3cb036c050286f474199996a7224	Version Fixed In:

Description Thiago Sueto 2022-01-17 23:42:41 UTC

From this precise commit onwards I can no longer see any webrunners in the Web Search KCM.

https://invent.kde.org/frameworks/kio/-/commit/aab35e6e514366e433b612636b520019b2413176

This is definitely a regression. It happens with a new user, I have noticed this after an update to my distro's git packages (Krypton), compiled KIO myself from master and could reproduce it, downgraded to a commit prior to the one I linked above and all webrunners show up again. The commit where things work and the bug is no longer reproducible is:

https://invent.kde.org/frameworks/kio/-/commit/102b16b5a51136c2540a1b462f8389e27138a1f9

Comment 1 Nate Graham 2022-01-18 02:33:21 UTC

Can confirm.

In the future, when you identify the exact commit (awesome!) feel free to CC the author.

Comment 2 Alexander Lohnau 2022-01-20 05:25:52 UTC

I did some bisecting, but came not up with sth. useful.

https://invent.kde.org/frameworks/kio/-/merge_requests/722 should be the correct fix

Comment 3 Bug Janitor Service 2022-01-20 18:15:16 UTC

A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/100

Comment 4 Alexander Lohnau 2022-01-20 19:47:00 UTC

Git commit 765ab0f3b28b3cb036c050286f474199996a7224 by Alexander Lohnau.
Committed on 20/01/2022 at 18:13.
Pushed by fvogt into branch 'master'.

Use BUILD* deprecation wrapper for virtual method

This took me hours to debug, because it caused pretty random behavior.

Distros should ideally backport this, since it will cause issues for consumers that want to disable deprecations.

M  +1    -1    src/kcmodule.h

https://invent.kde.org/frameworks/kconfigwidgets/commit/765ab0f3b28b3cb036c050286f474199996a7224