| Summary: | "performance mode disabled" and "charge limit set" message have unequal top paddings | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Photon <ncqm3qdz> |
| Component: | Power and Battery widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | bharadwaj.raju777, kde, me, nate, vrdhotre |
| Priority: | VLO | ||
| Version First Reported In: | git-stable-Plasma/5.24 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | 6.0 | |
| Sentry Crash Report: | |||
| Attachments: |
Battery applet
Battery applet -- with consistent measurements this time |
||
|
Description
Photon
2022-01-16 00:24:25 UTC
It seems that every item has it's own padding. Maybe it would be better if this padding was provided by the same place, just like the concept of a CSS class selector. This issue possibly affects other systray applets, but I haven't checked yet. There are always ways to improve, especially for reusable inhibition hints (those small labels with icons). We refactoring it lately, step by step. And patches are welcome :) But mind you, if you gonna measure distance between a lower bottom of lowercase letter "g" and a ceiling top notch of letter "b", "f" or any uppercase like "T" — it won't get you far in layout management. In fact, we have spent some efforts to ensure that text around battery's "progress bar" is padded by the same distance as those labels around brightness sliders. Created attachment 145526 [details]
Battery applet -- with consistent measurements this time
Your measurements are all wrong. One place you're measuring from the tail of a "y", some other place you're measuring from the bottom of an "a". Some place you're measuring to the top of a capital letter. Some other place something else.
I've attached an image with measurements made *consistently* from the bottom of a lowercase letter to the top of a lowercase letter. Most of the claimed inconsistencies are shown to not actually exist.
The only possible inconsistencies left after correcting the measurements are:
1) from "Battery health" to "Your battery is configured ..." is 29px, should be 36px
2) from "Power save" to "Performance mode ..." is 21px, should be 36px
The problem persisted due to the Disc was Dynamic, not Basic. As kdenlive do not support dynamic disks, I required to convert disk from dynamic to basic. I have followed this URL to perform required action : https://docs.microsoft.com/en-us/windows-server/storage/disk-management/change-a-dynamic-disk-back-to-a-basic-disk I have used its first method of removing all volumes and format the drive. As I was having very less data in disk. But you can use alternative method to convert dynamic disk to basic disk. Just search on google/youtube to convert dynamic disk to basic without losing data. You will get enough results to perform the required action. Vaibhav Dhotre, wrong bug? (In reply to ratijas from comment #6) > Vaibhav Dhotre, wrong bug? Yes. Sorry. By mistake I have posted in wrong bug. Ivan and Bharadwaj are right and, Bharadwaj's accurate measurements are ones you want to be using. Basically the only thing actionable here is to make the battery charge limit message have equal top padding as the performance mode message. These inconsistencies have been effectively resolved during the split of the applet between power and brightness for Plasma 6. |