Bug 448546

Thanks!

hm.... There's several crashes in that file, but this one is the most common:


krita.exe caused an Access Violation at location 00007FFAFFB217F0 in module libkritaimage.dll Reading from location 0000000000000020.

AddrPC           Params
00007FFAFFB217F0 0000000056D3BF55 000000003CE5A270 000000003D88FB40  libkritaimage.dll!0x2317f0 KisScalarKeyframe::value+0x0
00007FFAFF92C787 00000000202F7CA0 000000006FC621FB 01D80A3CA6484DFF  libkritaimage.dll!0x3c787 KisAnimatedOpacityProperty::set+0x337
00007FFAF8FA6871 0000000000000000 00007FFAFFA2E0D8 000000004681C8F0  kritaanimationdocker.dll!0x6871 std::_Function_handler<KUndo2Command* (), KisAnimUtils::createKeyframeCommand(KisSharedPtr<KisImage>, KisSharedPtr<KisNode>, QString const&, int, bool, KUndo2Command*)::{lambda()#1}>::_M_invoke+0x211
00007FFB7E9889F6 000000004681C8F0 000000004681C8F0 0000000037DDED80  libkritacommand.dll!0x89f6 KisCommandUtils::LambdaCommand::populateChildCommands+0x16
00007FFB7E9884CB 0000000029C91340 00007FFAFFA41B45 0000000000000000  libkritacommand.dll!0x84cb KisCommandUtils::AggregateCommand::redo+0x1b
00007FFAFFA2EB96 000000033CE5A370 00007FFAFEBEA3BD 0000000000000100  libkritaimage.dll!0x13eb96 KisStrokeStrategyUndoCommandBased::doStrokeCallback+0x76
00007FFAFFC39E70 0000000000000010 000000003CE5A370 000000004673C360  libkritaimage.dll!0x349e70 KisUpdateJobItem::run+0x90
00007FFAFEA18A90 0000000029C91F70 000000004673C300 0000000000000000  Qt5Core.dll!0x28a90 QThreadPool::tryStart+0x520
00007FFAFEA11AAF 0000000000000000 0000000000000000 0000000000000000  Qt5Core.dll!0x21aaf QThread::qt_metacall+0x69f
00007FFB94B154E0 0000000000000000 0000000000000000 0000000000000000  KERNEL32.DLL!0x154e0 BaseThreadInitThunk+0x10
00007FFB9524485B 0000000000000000 0000000000000000 0000000000000000  ntdll.dll!0x485b RtlUserThreadStart+0x2b

This one is a crash because Krita is trying to make an opacity keyframe, but failing? This one happens 5 times. Looking at it, there's a shared pointer being checked there (called m_channel->keyframeAt<KisScalarKeyframe>(time)), and that might actually not exist, which means the program gets confused and crashes.

The others are...

1x a crash with the layer properties changing
1x OpenGL crashing.
1x a crash when generating the frame-cache (that's what is used for playback)

My instinct is to check whether the pointer exists before we try to access it, but maybe Eoin has a more robust idea. Assigning it to him.

Hi there kmelisargzh, 

So I've poked around on my Windows build and cannot reproduce this issue on my machine. Could you do the following for me?

1) Please try uninstalling and installing Krita 5.0.2 again -- I'm mostly interested to know whether or not a fresh install will change the results here. If this was an upgrade, it could be that some of the old animation-related libraries stayed installed on your system which is causing an interference.

2) If a fresh installation does not solve your problem, please provide me with details regarding your system hardware and configuration (`Display > Canvas Acceleration` and  `Performance > Animation Cache` settings page details, in particular, would be nice to know here.)

Sorry for the inconvenience,
Eoin.

There is one safe assert in the log:

    SAFE ASSERT (krita): "m_d->requestedFrame == frame" in file C:\Packaging\workspace\Krita_Release_Windows64_Build\krita\libs\ui\KisAsyncAnimationRendererBase.cpp, line 133

https://invent.kde.org/graphics/krita/-/blob/v5.0.2/libs/ui/KisAsyncAnimationRendererBase.cpp#L133

(In reply to Eoin O'Neill from comment #2)
> Hi there kmelisargzh, 
> 
> So I've poked around on my Windows build and cannot reproduce this issue on
> my machine. Could you do the following for me?
> 
> 1) Please try uninstalling and installing Krita 5.0.2 again -- I'm mostly
> interested to know whether or not a fresh install will change the results
> here. If this was an upgrade, it could be that some of the old
> animation-related libraries stayed installed on your system which is causing
> an interference.
> 
> 2) If a fresh installation does not solve your problem, please provide me
> with details regarding your system hardware and configuration (`Display >
> Canvas Acceleration` and  `Performance > Animation Cache` settings page
> details, in particular, would be nice to know here.)
> 
> Sorry for the inconvenience,
> Eoin.

First of all, sorry for the late reply. Second of all, I think I figured it out! :D I looked at the Performance and just increased the memory limit (i dont know what its called in english, sorry) and now it works again! Thank you so much, and sorry for bothering you! Have a nice week.

kmelisargzh,

That's good to hear. :) Maybe we can do more to give more feedback for when crashes occur due to certain settings. I'll look into that at some point as well. 

Hope you have a good week,
Eoin