| Summary: | kwin_wayland crashes in KWin::Platform::requestOutputsChange() when external monitor is disconnected while multi-monitor mode is set to 'Switch to external screen' | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Patrick Silva <bugseforuns> |
| Component: | wayland-generic | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | kde, matejm98mthw, nate, xaver.hugl |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/24dc3abe918cde9007e19c4351e5778480f5bb75 | Version Fixed In: | 5.24 |
| Sentry Crash Report: | |||
|
Description
Patrick Silva
2022-01-14 12:05:41 UTC
Cannot reproduce with those exact steps and hardware. No crash for me. I think I have the same issue: https://pastebin.com/F0zTDwhz but I got it by different approach. 1. external monitor connected via HDMI 2. external monitor is the only one enabled and it's also set as primary 3. I left my pc running with the screen locked 4. when I returned, I logged in and saw only a black screen with a cursor, kwin, plasmashell and all apps were killed. This is on Arch Linux, Plasma 5.24 Beta. I have the same issue as #2: gdb bt -full https://pastebin.pl/view/04d358b4 My setup: laptop with internal screen (1920x1080), eDP, lid closed external monitor (2560x1600), HDMI Steps: 1. Enter Wayland session 2. Turn off the external monitor via its power button 3. Turn on the monitor 4. Notice that kwin has crashed, the desktop itself still seems to function but any applications opened prior to step 2 are lost Versions: Operating System: Arch Linux KDE Plasma Version: 5.23.90 KDE Frameworks Version: 5.90.0 Qt Version: 5.15.2 Kernel Version: 5.15.10-zen1-1-zen (64-bit) Graphics Platform: Wayland Processors: 16 × AMD Ryzen 7 4800H with Radeon Graphics Memory: 29.8 GiB of RAM Graphics Processor: AMD RENOIR Some extra kwin debug logs, produced with: > QT_LOGGING_RULES="kwin_wayland_drm.debug=true;kwin_core.debug=true;kwin_wayland_backend.debug=true" http://ix.io/3Mn2 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1905 I can't reproduce the bug, can someone here verify that this works? (In reply to Zamundaaa from comment #6) > I can't reproduce the bug, can someone here verify that this works? I built kwin from git (Plasma 5.24 + your patch) and if I unplug my monitor I get a crash https://pastebin.com/aSQWaQuM (In reply to Zamundaaa from comment #6) > I can't reproduce the bug, can someone here verify that this works? After applying that patch, KWin no longer crashes when turning off/on the external monitor. (In reply to hexchain from comment #8) > (In reply to Zamundaaa from comment #6) > > I can't reproduce the bug, can someone here verify that this works? > > After applying that patch, KWin no longer crashes when turning off/on the > external monitor. How did we get different results? Are we not having the same issue? (In reply to Matej Mrenica from comment #9) > (In reply to hexchain from comment #8) > > (In reply to Zamundaaa from comment #6) > > > I can't reproduce the bug, can someone here verify that this works? > > > > After applying that patch, KWin no longer crashes when turning off/on the > > external monitor. > > How did we get different results? Are we not having the same issue? Looking at our backtraces, I'd guess we have the same issue (#2 and #3), but what you just encountered (#7) may be a new one. Git commit e0a8fa778e3dce508695155c7d5a9a1e0bddd9f8 by Nate Graham, on behalf of Xaver Hugl. Committed on 18/01/2022 at 21:36. Pushed by ngraham into branch 'master'. backends/drm: fix output changes with the placeholder output As the placeholder output gets added or removed in response to other outputs getting enabled or disabled, the output list may change while iterating over them and applying changes. Related: bug 448474, bug 448697 FIXED-IN: 5.24 M +7 -3 src/backends/drm/drm_backend.cpp https://invent.kde.org/plasma/kwin/commit/e0a8fa778e3dce508695155c7d5a9a1e0bddd9f8 Git commit 24dc3abe918cde9007e19c4351e5778480f5bb75 by Nate Graham, on behalf of Xaver Hugl. Committed on 18/01/2022 at 21:37. Pushed by ngraham into branch 'Plasma/5.24'. backends/drm: fix output changes with the placeholder output As the placeholder output gets added or removed in response to other outputs getting enabled or disabled, the output list may change while iterating over them and applying changes. Related: bug 448474, bug 448697 FIXED-IN: 5.24 (cherry picked from commit e0a8fa778e3dce508695155c7d5a9a1e0bddd9f8) M +7 -3 src/backends/drm/drm_backend.cpp https://invent.kde.org/plasma/kwin/commit/24dc3abe918cde9007e19c4351e5778480f5bb75 (In reply to Matej Mrenica from comment #7) > I built kwin from git (Plasma 5.24 + your patch) and if I unplug my monitor > I get a crash https://pastebin.com/aSQWaQuM It's not the same crash but related. https://invent.kde.org/plasma/kwin/-/merge_requests/1908 should fix it (In reply to Zamundaaa from comment #13) > (In reply to Matej Mrenica from comment #7) > > I built kwin from git (Plasma 5.24 + your patch) and if I unplug my monitor > > I get a crash https://pastebin.com/aSQWaQuM > > It's not the same crash but related. > https://invent.kde.org/plasma/kwin/-/merge_requests/1908 should fix it It doesn't fix it for me, see: https://pastebin.com/zsrabTxv Added two more fixes to the MR that could cause the bug. If it still occurs with that, please open a new bug report and put me in CC so that we can gather more information |