Bug 448291

Summary: Skrooge file exported to SQLite loses user properties
Product: [Applications] skrooge Reporter: Marco Sanchotene <marco.sanchotene>
Component: generalAssignee: Guillaume DE BURE <guillaume.debure>
Status: RESOLVED FIXED    
Severity: normal CC: stephane
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: 25.1.0   
Platform: Snap   
OS: Linux   
Latest Commit: https://invent.kde.org/office/skrooge/commit/c08cae654c09c868944dc45c80c31aac6c37de0d Version Fixed/Implemented In:
Sentry Crash Report:

Description Marco Sanchotene 2022-01-11 23:39:03 UTC 
SUMMARY
A Skrooge file exported on version 2.24.6 to SQLite loses all user properties when opened on version 2.26.1.


STEPS TO REPRODUCE
1. Export a Skrooge file to SQLite on version 2.24.6.
2. Open the file on version 2.26.1.
3. Save the imported data on a new Skrooge file.

OBSERVED RESULT
The Skrooge file does not have the properties from the original Skrooge file exported to the SQLite file.

EXPECTED RESULT
The Skrooge file should have the properties from the original Skrooge file exported to the SQLite file.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 5.23
(available in About System)
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.3
Comment 1 Stephane MANKOWSKI 2022-01-12 16:59:31 UTC 
Git commit 2d29c0dca2b0003dcaf4361c1be7894f8b4c0353 by Stephane MANKOWSKI.
Committed on 12/01/2022 at 16:59.
Pushed by smankowski into branch 'master'.

Skrooge file exported to SQLite loses user properties

M  +3    -2    plugins/import/skrooge_import_skg/skgimportpluginskg.cpp
M  +-    --    tests/input/skgtestimportskg/all_types.skg
M  +9    -2    tests/skgbankmodelertest/skgtestimportskg.cpp

https://invent.kde.org/office/skrooge/commit/2d29c0dca2b0003dcaf4361c1be7894f8b4c0353
Comment 2 Stephane MANKOWSKI 2022-01-12 17:02:32 UTC 
Hi,
I did that:
1- Export in sqlite format
2- New document
3- Import the exported file (in step 1)

Result: the properties were well imported.

But, I found some errors (hyperlink of properties, ...), so I did a correction.

Could you confirm that this is the right scenario because I'm not able to reproduce it ?
Comment 3 Marco Sanchotene 2022-01-12 21:12:13 UTC 
(In reply to Stephane MANKOWSKI from comment #2)
> Hi,
> I did that:
> 1- Export in sqlite format
> 2- New document
> 3- Import the exported file (in step 1)
> 
> Result: the properties were well imported.
> 
> But, I found some errors (hyperlink of properties, ...), so I did a
> correction.
> 
> Could you confirm that this is the right scenario because I'm not able to
> reproduce it ?

Just to confirm, did you export the file using version 2.24.6 and imported it with 2.26.1?

I currently have only 2.26.1 installed. To install 2.24.6 in parallel is it by building it with the file here https://download.kde.org/stable/skrooge/? I'll need both to reproduce the issue once again.
Comment 4 Stephane MANKOWSKI 2022-01-13 13:15:32 UTC 
No, I didn't do the export with 2.24.6 but I don't see why this could have an impact.
Could you provide me a sample sqlite file to reproduce the issue ?
Comment 5 Marco Sanchotene 2022-01-16 23:36:41 UTC 
After further analysis, I realized the properties tab was with the "For: Selection" option selected, that is why the properties were not being displayed. I can confirm this is not a defect and that the export worked correctly. Apologies for the false positive report.
Comment 6 Stephane MANKOWSKI 2022-01-18 20:43:07 UTC 
Git commit c08cae654c09c868944dc45c80c31aac6c37de0d by Stephane MANKOWSKI.
Committed on 18/01/2022 at 20:42.
Pushed by smankowski into branch 'master'.

Skrooge file exported to SQLite loses user properties

M  +15   -15   skgbasemodeler/skgpropertyobject.cpp

https://invent.kde.org/office/skrooge/commit/c08cae654c09c868944dc45c80c31aac6c37de0d