| Summary: | In the dark theme the light icons not working on Windows 10 | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Peter <benedekppeter> |
| Component: | Usability-Themes | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, iwannaberich, metzpinguin |
| Priority: | NOR | ||
| Version: | 7.5.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | Version Fixed In: | 7.5.0 | |
| Sentry Crash Report: | |||
|
Description
Peter
2022-01-09 17:33:18 UTC
Yes, the problem is known, we are already working on it. So far, however, no solution under Windows. It is related to the updated KF5 libraries. Maik Gilles, the two resource files breeze.rcc and breeze-dark.rcc are identical, they both contain the dark icons. Maik I see this message in the Breeze Changelog, the icon theme must be created. * Install dark icons via execute_process to use copy command (kde#444095) Maik Git commit d4fac5842e336eecb9c00157250e94bc04ce5a3d by Gilles Caulier. Committed on 11/01/2022 at 12:52. Pushed by cgilles into branch 'master'. Update code and rules to compile qrc alias binary under MXE for Windows. M +46 -20 project/bundles/mxe/icon-rcc/CMakeLists.txt R +11 -11 project/bundles/mxe/icon-rcc/qrcAlias.cpp [from: project/bundles/mxe/icon-rcc/main.cpp - 088% similarity] https://invent.kde.org/graphics/digikam/commit/d4fac5842e336eecb9c00157250e94bc04ce5a3d Git commit a625add4ea9d7d0afed40e1d66c40bf86d3d860f by Gilles Caulier. Committed on 11/01/2022 at 12:56. Pushed by cgilles into branch 'master'. Update code and rules to compile qrc alias binary under Macports for MacOS. M +46 -20 project/bundles/macports/icon-rcc/CMakeLists.txt R +11 -11 project/bundles/macports/icon-rcc/qrcAlias.cpp [from: project/bundles/macports/icon-rcc/main.cpp - 088% similarity] https://invent.kde.org/graphics/digikam/commit/a625add4ea9d7d0afed40e1d66c40bf86d3d860f Git commit ed1d0b6e6ea3e1af9911009c2d058674935a4e7e by Gilles Caulier. Committed on 11/01/2022 at 12:58. Pushed by cgilles into branch 'master'. Update code and rules to compile qrc alias binary under Linux Mageia7 for AppImage. M +46 -20 project/bundles/appimage/icon-rcc/CMakeLists.txt R +11 -11 project/bundles/appimage/icon-rcc/qrcAlias.cpp [from: project/bundles/appimage/icon-rcc/main.cpp - 088% similarity] https://invent.kde.org/graphics/digikam/commit/ed1d0b6e6ea3e1af9911009c2d058674935a4e7e Git commit b5151a2918b6345772ee2d65eafc40252955d2fa by Gilles Caulier. Committed on 11/01/2022 at 14:23. Pushed by cgilles into branch 'master'. fix rcc file name to copy in bundle M +26 -26 project/bundles/mxe/04-build-installer.sh https://invent.kde.org/graphics/digikam/commit/b5151a2918b6345772ee2d65eafc40252955d2fa Git commit 0cdb78aff4ca1b554837be0e186f78a5edd8dae1 by Gilles Caulier. Committed on 11/01/2022 at 14:26. Pushed by cgilles into branch 'master'. fix rcc file name to copy in the bundle M +2 -2 project/bundles/macports/04-build-installer.sh M +0 -0 project/bundles/macports/installer/digikam.pkgproj https://invent.kde.org/graphics/digikam/commit/0cdb78aff4ca1b554837be0e186f78a5edd8dae1 Git commit deef8e8517ad0e7b76dc63063c517be553a9a51e by Gilles Caulier. Committed on 11/01/2022 at 14:28. Pushed by cgilles into branch 'master'. Fix rcc file name to copy in the bundle M +19 -19 project/bundles/appimage/04-build-appimage.sh https://invent.kde.org/graphics/digikam/commit/deef8e8517ad0e7b76dc63063c517be553a9a51e MAik, In KF5 5.90 just released, i can see in Breeze changelog : ### Breeze Icons * Support old cmake * Add places-book, -library, -comic icons * Include "*@*" in the icon_files list for installation * Make FM and system settings icons color-aware * Improve installation of light fallback icons Q : do i need to upgrade from KF5 5.89 to 5.90 in all bundles ? Gilles Maik, i rebuild all bundles. I just tested the MacOS version, and... now, no icons are displayed. https://i.imgur.com/lBMatku.png But the breeze rcc containers are there and found at run time, but there are not present on theme icon combo box from setup/misc bash-3.2$ uname -a Darwin MacBook-Pro-de-gilles.local 20.6.0 Darwin Kernel Version 20.6.0: Wed Nov 10 22:23:07 PST 2021; root:xnu-7195.141.14~1/RELEASE_X86_64 x86_64 bash-3.2$ pwd /Applications/digiKam.org/digikam.app/Contents/MacOS bash-3.2$ ls digikam digikam.dSYM bash-3.2$ ./digikam digikam.widgets: Breeze icons resource file found digikam.widgets: Breeze-dark icons resource file found digikam.general: Qt standard translations removed: 0 digikam.general: Qt standard translations path: "/Applications/digiKam.org/digikam.app/Contents/Resources/translations" digikam.general: Loaded Qt standard translations "en_US" from catalog "qt" digikam.general: Loaded Qt standard translations "en_US" from catalog "qtbase" digikam.general: Loaded Qt standard translations "en_US" from catalog "qt_help" digikam.general: Loaded Qt standard translations "en_US" from catalog "qtdeclarative" digikam.general: Loaded Qt standard translations "en_US" from catalog "qtquickcontrols" digikam.general: Loaded Qt standard translations "en_US" from catalog "qtquickcontrols2" digikam.general: Loaded Qt standard translations "en_US" from catalog "qtmultimedia" digikam.general: Loaded Qt standard translations "en_US" from catalog "qtwebengine" digikam.general: Loaded Qt standard translations "en_US" from catalog "qtxmlpatterns" digikam.general: Loaded Qt ECM translations "en" from catalog "kcoreaddons5_qt" digikam.general: Loaded Qt ECM translations "en" from catalog "kwidgetsaddons5_qt" digikam.general: Switch to widget style: "Fusion" digikam.general: AlbumWatch is disabled digikam.general: Database Parameters: Type: "QMYSQL" DB Core Name: "digikam" DB Thumbs Name: "digikam" DB Face Name: "digikam" DB Similarity Name: "digikam" Connect Options: "UNIX_SOCKET=/Users/gilles/Library/Application Support/digikam/digikam/db_misc/mysql.socket" Host Name: "" Host port: -1 Internal Server: true Internal Server Path: "/Users/gilles/Pictures" Internal Server Admin Cmd: "/Applications/digiKam.org/digikam.app/Contents/lib/mariadb/bin/mysqladmin" Internal Server Serv Cmd: "/Applications/digiKam.org/digikam.app/Contents/lib/mariadb/bin/mysqld" Internal Server Init Cmd: "/Applications/digiKam.org/digikam.app/Contents/lib/mariadb/bin/mysql_install_db" Username: "root" Password: "" digikam.databaseserver: Database Parameters: Type: "QMYSQL" DB Core Name: "digikam" DB Thumbs Name: "digikam" DB Face Name: "digikam" DB Similarity Name: "digikam" Connect Options: "UNIX_SOCKET=/Users/gilles/Library/Application Support/digikam/digikam/db_misc/mysql.socket" Host Name: "" Host port: -1 Internal Server: true Internal Server Path: "/Users/gilles/Pictures" Internal Server Admin Cmd: "/Applications/digiKam.org/digikam.app/Contents/lib/mariadb/bin/mysqladmin" Internal Server Serv Cmd: "/Applications/digiKam.org/digikam.app/Contents/lib/mariadb/bin/mysqld" Internal Server Init Cmd: "/Applications/digiKam.org/digikam.app/Contents/lib/mariadb/bin/mysql_install_db" Username: "root" Password: "" digikam.databaseserver: Internal Server data path: "/Users/gilles/Pictures/.mysql.digikam/db_data" digikam.databaseserver: The mysql configuration was already up-to-date: "/Users/gilles/Library/Application Support/digikam/digikam/mysql.conf" digikam.databaseserver: Database server: "/Applications/digiKam.org/digikam.app/Contents/lib/mariadb/bin/mysqld" ("--defaults-file=/Users/gilles/Library/Application Support/digikam/digikam/mysql.conf", "--datadir=/Users/gilles/Pictures/.mysql.digikam/db_data", "--basedir=/Applications/digiKam.org/digikam.app/Contents//lib/mariadb/", "--socket=/Users/gilles/Library/Application Support/digikam/digikam/db_misc/mysql.socket") digikam.databaseserver: Internal database server started digikam.databaseserver: Running 0 seconds... digikam.dbengine: Loading SQL code from config file "/Applications/digiKam.org/digikam.app/Contents/Resources/digikam/database/dbconfig.xml" digikam.dbengine: Checking XML version ID => expected: 3 found: 3 digikam.coredb: Core database: running schema update digikam.coredb: Core database: have a structure version 15 digikam.coredb: Core database: makeUpdates 15 to 15 digikam.database: Creating new Location "/Users/gilles/Pictures" uuid "volumeid:?uuid=10d4acb6-7f80-30a1-8399-5c2b5a4fd235" digikam.database: location for "/System/Volumes/Data/Users/gilles/Pictures" is available true digikam.general: KMemoryInfo: Platform identified : "Unknown" digikam.general: KMemoryInfo: TotalRam: -1 digikam.general: Allowing a cache size of 60 MB digikam.thumbsdb: ThumbDB SelectThumbnailSetting val ret = 0 digikam.thumbsdb: ThumbDB SelectThumbnailSetting val ret = 0 digikam.thumbsdb: Thumbs database: have a structure version "3" digikam.general: Thumbnails database ready for use digikam.similaritydb: SimilarityDb SelectSimilaritySetting val ret = 0 digikam.similaritydb: SimilarityDb SelectSimilaritySetting val ret = 0 digikam.similaritydb: Similarity database: have a structure version "1" digikam.similaritydb: Similarity database ready for use dbus[15797]: Dynamic session lookup supported but failed: launchd did not provide a socket path, verify that org.freedesktop.dbus-session.plist is loaded! digikam.dimg: ("/System/Library/ColorSync/Profiles", "/Library/ColorSync/Profiles") digikam.dimg: The original Adobe RGB (1998) profile has been found at "/System/Library/ColorSync/Profiles/AdobeRGB1998.icc" digikam.general: Camera XML data: "/Users/gilles/Library/Application Support/digikam/cameras.xml" digikam.general: Starting to load external tools. digikam.general: Parsing plugins from ("/Applications/digiKam.org/digikam.app/Contents/libexec/qt5/plugins/digikam/") digikam.general: Plugins found: 133 Ok i understand, rcc files do not contain icons in fact but a big mess. I will fix it. Gilles Gilles, I downloaded and compiled a resource file extractor to extract the Breeze.rcc files to see the change. Currently there is a typo in it breeze.rcc => brezze.rcc. The current brezze.rcc contains CMake files. If there is no index.theme, they will not appear in the setup. Maik Git commit 82255e165ba282437247aad6dd82175491f300bc by Gilles Caulier. Committed on 12/01/2022 at 07:55. Pushed by cgilles into branch 'master'. RCC breeze icons sets are now based on KF5 native build of framework due to non compatibility with cross-compiling. M +11 -51 project/bundles/mxe/icon-rcc/CMakeLists.txt A +30 -0 project/bundles/mxe/icon-rcc/breeze-mxe-linux.patch D +0 -119 project/bundles/mxe/icon-rcc/qrcAlias.cpp https://invent.kde.org/graphics/digikam/commit/82255e165ba282437247aad6dd82175491f300bc Git commit 259601ba01ca9f4d44dc01d3bd41efa406e02346 by Gilles Caulier. Committed on 12/01/2022 at 08:48. Pushed by cgilles into branch 'master'. Fix build of native breeze icons set for MXE. M +5 -3 project/bundles/mxe/01-build-mxe.sh M +12 -3 project/bundles/mxe/04-build-installer.sh M +4 -3 project/bundles/mxe/icon-rcc/CMakeLists.txt M +19 -9 project/bundles/mxe/icon-rcc/breeze-mxe-linux.patch https://invent.kde.org/graphics/digikam/commit/259601ba01ca9f4d44dc01d3bd41efa406e02346 Hi all, The first Windows 7.5.0 pre-release installer version with a native breeze icons set build to package icons as RCC container is published this morning at usual place. Maik, The compilation trace of breeze give this trace : -- Build files have been written to: /mnt/data/7.x/project/bundles/mxe/icon-rcc/icon-rcc-prefix/src/icon-rcc-build [ 37%] Performing build step for 'icon-rcc' [ 3%] Automatic MOC for target newline [ 7%] Generating 24px icons-dark [ 14%] Automatic MOC for target qrcAlias [ 14%] Generating 24px icons [ 18%] Automatic MOC for target dupe [ 22%] Automatic MOC for target symlink [ 25%] Automatic MOC for target scalable [ 25%] Built target newline_autogen [ 25%] Built target scalable_autogen [ 25%] Built target dupe_autogen [ 25%] Built target qrcAlias_autogen [ 25%] Built target symlink_autogen [ 37%] Built target qrcAlias [ 48%] Built target newline [ 48%] Built target breeze-icons-mkdir [ 48%] Built target breeze-icons-dark-mkdir [ 59%] Built target dupe [ 62%] Generating breeze-icons-dark.rcc [ 66%] Generating breeze-icons.rcc [ 77%] Built target symlink [ 88%] Built target scalable apps/22/hotspot.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.821 5.821" animations/22/process-working.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 22 330" actions/22/fingerprint.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208334 5.8208334" [ 88%] Built target breeze-generate-24px-versions-dark apps/22/elisa.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208 5.8208" apps/22/hotspot.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.821 5.821" emotes/22/face-clown.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-crying.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-smile.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-glasses.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-kiss.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-cool.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-angry.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-sad.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-raspberry.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/drink-beer.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-smile-big.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-smile-grin.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-wink.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-pirate.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-in-love.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-confused.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-embarrassed.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/food-cake.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-surprise.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-sick.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-hug-right.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-plain.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-angel.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-laughing.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-worried.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-yawn.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-ninja.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-smirk.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-uncertain.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-sleeping.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/drink-martini.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-devilish.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-quiet.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" emotes/22/face-hug-left.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" mimetypes/22/text-x-scala.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 16 16" mimetypes/22/application-x-root.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208332 5.8208335" mimetypes/22/text-x-go.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 16 16" mimetypes/22/text-x-lua.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 16 16" preferences/22/preferences-system-network-ethernet.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8210625 5.8210625" animations/22/process-working.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 22 330" actions/22/fingerprint.svg SKIPPED: not square or incorrect viewBox viewBox="0 0 5.8208334 5.8208334" [ 88%] Built target breeze-generate-24px-versions [ 92%] Validating SVG [ 92%] Built target breeze-validate-svg [ 96%] Built target breeze-icons-dark-rcc [100%] Built target breeze-icons-rcc [ 50%] No install step for 'icon-rcc' [ 62%] Completed 'icon-rcc' [100%] Built target icon-rcc What do you think about the error lines for some SVG icons ? Gilles Maik, Under Windows, the GUI do not show icons again. But rcc files are here and loaded : [1492] digikam.general: Loading DrMinGw run-time... [1492] digikam.general: DrMinGw run-time loaded. [1492] digikam.general: DrMinGw crash-file will be located at: "C:\\Users\\gilles\\AppData\\Local\\digikam_crash.log" [1492] digikam.widgets: Breeze icons resource file found [1492] digikam.widgets: Breeze-dark icons resource file found [1492] digikam.general: Qt standard translations removed: 14 [1492] digikam.general: Qt standard translations path: "C:/Program Files/digiKam/translations" [1492] digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qt" [1492] digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qtbase" [1492] digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qt_help" [1492] digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qtdeclarative" [1492] digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qtquickcontrols" [1492] digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qtmultimedia" [1492] digikam.general: Loaded Qt standard translations "fr_FR" from catalog "qtxmlpatterns" [1492] digikam.general: Loaded Qt ECM translations "en" from catalog "kcoreaddons5_qt" [1492] digikam.general: Loaded Qt ECM translations "en" from catalog "kwidgetsaddons5_qt" ... and i double checked the rcc files, both contains the icons as expected. Gilles Maik, In non compressed qrc file for icon breeze set, the xml content is this one : [gilles@localhost icons]$ cat tmp.qrc <!DOCTYPE RCC><RCC version="1.0"> <qresource> <file>./actions/12/object-fill.svg</file> <file>./actions/12/object-stroke-style.svg</file> <file>./actions/12/object-stroke.svg</file> <file>./actions/12/transform-affect-gradient.svg</file> <file>./actions/12/transform-affect-pattern.svg</file> <file>./actions/12/transform-affect-rounded-corners.svg</file> <file>./actions/12/transform-affect-stroke.svg</file> <file>./actions/16/accept_signal.svg</file> <file>./actions/16/accept_time_event.svg</file> <file>./actions/16/acrobat.svg</file> <file>./actions/16/action-albumfolder-importdir2.svg</file> <file>./actions/16/action-rss_tag.svg</file> <file>./actions/16/activities.svg</file> <file>./actions/16/activity-fork.svg</file> <file>./actions/16/actor.svg</file> <file>./actions/16/add-placemark.svg</file> <file>./actions/16/add-subtitle.svg</file> <file>./actions/16/address-book-new.svg</file> <file>./actions/16/addressbook-details.svg</file> <file>./actions/16/adjustcol.svg</file> <file>./actions/16/adjustrow.svg</file> <file>./actions/16/adress-book-new.svg</file> <file>./actions/16/aggregation.svg</file> <file>./actions/16/akonadi-phone-home.svg</file> <file>./actions/16/albumfolder-importdir.svg</file> <file>./actions/16/albumfolder-importimages.svg</file> <file>./actions/16/albumfolder-new.svg</file> <file>./actions/16/albumfolder-properties.svg</file> <file>./actions/16/albumfolder-user-trash.svg</file> <file>./actions/16/align-horizontal-baseline.svg</file> <file>./actions/16/align-horizontal-bottom-out.svg</file> <file>./actions/16/align-horizontal-center.svg</file> <file>./actions/16/align-horizontal-left-out.svg</file> <file>./actions/16/align-horizontal-left-to-anchor.svg</file> <file>./actions/16/align-horizontal-left.svg</file> <file>./actions/16/align-horizontal-right-out.svg</file> <file>./actions/16/align-horizontal-right-to-anchor.svg</file> <file>./actions/16/align-horizontal-right.svg</file> ... So sub icon directories are hosted on the root of hierarchy. Gilles Maik, If i'm not too wrong, we expect a icons sub directory after root in hierarchy : https://invent.kde.org/graphics/digikam/-/blob/master/core/libs/widgets/mainview/dxmlguiwindow.cpp#L969 Gilles The directory structure in the resource file must be exactly as in a real installation. So icons/breeze/actions/12 ... Also, the index.theme must be present in the breeze folder. resources extractor: https://github.com/tatokis/qresExtract Maik Maik, Right about the icons hierarchy, but... this RCC (or QRC prealably) is computed by... breeze-icon KF5 component as well... There is no more customized code for installer. So my Q is where is the problem ? Gilles Under MacOS, when i recompile breeze-icons component with the RCC generation cmake option, this give a QRC file with this give exactly the same result than the native compile under Linux for MXE. Gilles Maik, I extracted the breeze.rcc file from the Windows tarball and i can see this hierarchy : [gilles@localhost breeze]$ cat breeze.qrc | more <!DOCTYPE RCC><RCC version="1.0"> <qresource> <file>icons/aliased.qrc</file> <file>icons/breeze/actions/12/object-fill.svg</file> <file>icons/breeze/actions/12/object-stroke-style.svg</file> <file>icons/breeze/actions/12/object-stroke.svg</file> <file>icons/breeze/actions/12/transform-affect-gradient.svg</file> <file>icons/breeze/actions/12/transform-affect-pattern.svg</file> <file>icons/breeze/actions/12/transform-affect-rounded-corners.svg</file> <file>icons/breeze/actions/12/transform-affect-stroke.svg</file> <file>icons/breeze/actions/16/accept_signal.svg</file> <file>icons/breeze/actions/16/acrobat.svg</file> <file>icons/breeze/actions/16/activities.svg</file> <file>icons/breeze/actions/16/add-subtitle.svg</file> <file>icons/breeze/actions/16/address-book-new.svg</file> <file>icons/breeze/actions/16/adjustcol.svg</file> <file>icons/breeze/actions/16/adjustrow.svg</file> <file>icons/breeze/actions/16/aggregation.svg</file> <file>icons/breeze/actions/16/akonadi-phone-home.svg</file> <file>icons/breeze/actions/16/align-horizontal-baseline.svg</file> <file>icons/breeze/actions/16/align-horizontal-bottom-out.svg</file> <file>icons/breeze/actions/16/align-horizontal-center.svg</file> <file>icons/breeze/actions/16/align-horizontal-left-out.svg</file> <file>icons/breeze/actions/16/align-horizontal-left-to-anchor.svg</file> <file>icons/breeze/actions/16/align-horizontal-left.svg</file> <file>icons/breeze/actions/16/align-horizontal-right-out.svg</file> <file>icons/breeze/actions/16/align-horizontal-right-to-anchor.svg</file> <file>icons/breeze/actions/16/align-horizontal-right.svg</file> <file>icons/breeze/actions/16/align-horizontal-top-out.svg</file> <file>icons/breeze/actions/16/align-vertical-baseline.svg</file> <file>icons/breeze/actions/16/align-vertical-bottom-out.svg</file> <file>icons/breeze/actions/16/align-vertical-bottom.svg</file> <file>icons/breeze/actions/16/align-vertical-center.svg</file> <file>icons/breeze/actions/16/align-vertical-top-out.svg</file> <file>icons/breeze/actions/16/align-vertical-top.svg</file> <file>icons/breeze/actions/16/amarok_cart_add.svg</file> <file>icons/breeze/actions/16/amarok_cart_remove.svg</file> <file>icons/breeze/actions/16/amarok_cart_view.svg</file> <file>icons/breeze/actions/16/amarok_change_language.svg</file> <file>icons/breeze/actions/16/anchor.svg</file> <file>icons/breeze/actions/16/application-exit.svg</file> ... So it miss icons/breeze/ on front of file paths in resource description. Note : I can see the breeze and breeze-dark rcc files have exactly the same size in archive, and the contents is exactly the same. With the breeze-icons KF5 component way, the file have a different size and the contents is not the same. This is certainly the origin of the problem finally. Gilles Git commit 253aef83be4d32e7f7e4fa3fff2dab55e19eefd4 by Gilles Caulier. Committed on 12/01/2022 at 10:48. Pushed by cgilles into branch 'master'. Smae than MXE, use breeze-icons KF5 comonent to compile RCC container for MacOS bundle M +7 -1 project/bundles/3rdparty/ext_kf5_frameworks/CMakeLists.txt M +2 -26 project/bundles/macports/04-build-installer.sh D +0 -70 project/bundles/macports/icon-rcc/CMakeLists.txt D +0 -119 project/bundles/macports/icon-rcc/qrcAlias.cpp https://invent.kde.org/graphics/digikam/commit/253aef83be4d32e7f7e4fa3fff2dab55e19eefd4 Git commit 636e4ad9b91fdf3c1d0e5d3496ad578267e22a37 by Gilles Caulier. Committed on 12/01/2022 at 13:20. Pushed by cgilles into branch 'master'. MXE: Add prefix to RCC file while embeding icons resource M +0 -1 project/bundles/mxe/04-build-installer.sh M +24 -2 project/bundles/mxe/icon-rcc/breeze-mxe-linux.patch https://invent.kde.org/graphics/digikam/commit/636e4ad9b91fdf3c1d0e5d3496ad578267e22a37 Git commit a0ed184afe8c9ff37871eac0aa3aada959648459 by Gilles Caulier. Committed on 12/01/2022 at 13:34. Pushed by cgilles into branch 'master'. Apply patch to breeze about rcc prefix for AppImage and MacOS M +1 -1 project/bundles/3rdparty/ext_kf5_frameworks/CMakeLists.txt R +26 -0 project/bundles/3rdparty/ext_kf5_frameworks/breeze-dropsvg-rccprefix.patch [from: project/bundles/3rdparty/ext_kf5_frameworks/breeze-icons-drop-svg.patch - 086% similarity] https://invent.kde.org/graphics/digikam/commit/a0ed184afe8c9ff37871eac0aa3aada959648459 Hi all, Voilà, With my last commits in git/master, now the icons are back in the Windows version. Please try with installer digiKam-7.5.0-20220112T092955-Win64.exe MacOS and AppImage bundles will come soon. Best Gilles NOTE: Installer is available at usual place of course : https://files.kde.org/digikam/ Git commit 1e65b26c4eb12770a258de6cb1581b19b4d3315b by Gilles Caulier. Committed on 12/01/2022 at 15:32. Pushed by cgilles into branch 'master'. AppImage: use same rules thanfor MacOS to bundle breeze icons as resource M +1 -0 project/bundles/appimage/01-build-host.sh M +24 -41 project/bundles/appimage/04-build-appimage.sh D +0 -70 project/bundles/appimage/icon-rcc/CMakeLists.txt D +0 -119 project/bundles/appimage/icon-rcc/qrcAlias.cpp https://invent.kde.org/graphics/digikam/commit/1e65b26c4eb12770a258de6cb1581b19b4d3315b MacOS installer published today is also updated and icons are back... AppImage is under progress... Gilles Caulier Icons work fine again under Windows. Maik Hi Peter, All bundle 7.5.0 pre-release are now updated online and ready to test. Can you reproduce the problem under Windows 10 ? Best Gilles Caulier (In reply to caulier.gilles from comment #32) > Hi Peter, > > All bundle 7.5.0 pre-release are now updated online and ready to test. Can > you reproduce the problem under Windows 10 ? > > Best > > Gilles Caulier Hi Gilles, I can't reproduce anymore. Work fine. Thanks! Great thanks for the feedback. Note : We will release 7.5.0 this week end. Gilles Caulier (In reply to caulier.gilles from comment #34) > Great thanks for the feedback. > > Note : We will release 7.5.0 this week end. > > Gilles Caulier Digikam 7.5.0 very excellent work. Fast and stable. Congratulation! |
