Bug 447902

Summary:	Highlight Editing UI does not work as expected
Product:	[Frameworks and Libraries] frameworks-syntax-highlighting	Reporter:	Mark Greenwood <fatgerman>
Component:	framework	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	waqar.17a
Priority:	NOR
Version First Reported In:	5.88.0
Target Milestone:	---
Platform:	Manjaro
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Mark Greenwood 2022-01-03 22:44:33 UTC

SUMMARY
***
When using the Color Theme editing UI in KDevelop or Kate, it does not apply the colors I select. For some things it does, but for others -eg 'Function' changing the color makes no difference to the display. Even editing the theme file by hand does not make a difference.
***

STEPS TO REPRODUCE
1. Open the Color Theme Editor in eg KDevelop
2. Make a copy of one of the built-in themes.
3. Set the new theme as the default and then start changing colors and hitting 'Apply'. Some work, some do not. This applies to both the Default Colors and the Language Specific Highlighting. The list of what does not work is extensive and seems to be Language-dependant, but at least for me it always includes 'Function'. Changing the text to Bold *does* work, but changing the color does not.

OBSERVED RESULT
As an experiment I changed every single color for the Default Settings, PHP/PHP and PHP/HTML Languages to bright red. Most things went red, but functions, variables, and some other elements did not. Variables were observed to be in 3 different colors with no apparent logic to what color was used when.

EXPECTED RESULT
The colors I select should be used consistently everywhere.

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: Manjaro-ARM RPi
(available in About System)
KDE Plasma Version: 5.23.4
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
This is the only thing stopping me from using KDevelop, it has a killer feature set but I have a color theme I've got used to over 20 years and I cannot cope without it.

Comment 1 Waqar Ahmed 2022-01-04 19:01:44 UTC

Assuming kdevelop has some kind of semantic highlighting for php or your target language, those semantic colors will override what you choose in the theme.

If the above is not the case then most probably PHP doesn't have support for highlighting functions. But if making the "function" bold works, then the color should work too. If it doesn't that's a bug. So, in short, it kind of depends on how good the syntax parsing support for a language is. Try with Javascript for e.g, I recall it had support for coloring functions so changing colors should work with JS files but C++ doesn't so it will have no affect.

Comment 2 Mark Greenwood 2022-01-04 20:57:18 UTC

Thanks for the quick reply, you've made a lot of things clearer. i had no idea that semantic parsing would affect the colours. Indeed, Kdevelop has some sliders to affect the intensity of that. When I set them to zero then the syntax highlighting works as I expect. Having 2 things doing syntax colouring simultaneously is confusing as hell, hut I guess not relevant to this bug. I'm still not able to set the colours I want to on the elements I want to, but your comments make me suspect that it's the fault of the parser, not the syntax colouring.

Comment 3 Bug Janitor Service 2022-01-19 04:36:36 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 4 Bug Janitor Service 2022-02-03 04:38:15 UTC

This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!