| Summary: | Could not open a PDF file in Krita 5.0.0 in macOS | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Keith Kmichik <keith.kmichik> |
| Component: | File formats | Assignee: | amyspark <amy> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahab.greybeard, amy, ghevan |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | macOS (DMG) | ||
| OS: | macOS | ||
| URL: | https://invent.kde.org/graphics/krita/-/commit/d523e7de2c6ed9a89bab0d96d6a3b928c680b314 | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/602e55754200d02dcd463b0d666a7bebaf4ec76b | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | four page .pdf test file | ||
|
Description
Keith Kmichik
2022-01-02 23:45:04 UTC
Created attachment 145080 [details]
four page .pdf test file
I can't test macOS but for Linux and Windows 10 I see the following:-
Linux:
4.4.8 takes 5 seconds to open the 'Archoil' .pdf file.
On Closing, there is no warning or offer to Save, etc.
5.0.0 takes about 40 seconds to open the document.
On Closing, there is no warning or offer to Save.
Windows 10:
4.4.8 takes 5 seconds to open it.
On Closing, it gives a warning and an offer to Save, etc.
5.0.0 takes 40 seconds to open it.
On Closing, it does not give any warning etc.
Not a Krita bug, rather CI; our dependencies build for macOS is *still* broken because of a failed fontconfig build: https://binary-factory.kde.org/job/Krita_Nightly_MacOS_Dependency_Build/119/consoleText fontconfig seems to need autotools A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1272 Git commit 2814f3f7a555b8359230e157c306dbd53576dddc by L. E. Segovia. Committed on 04/01/2022 at 02:13. Pushed by rempt into branch 'master'. Fix macOS fontconfig build Modifications to autotools-based builds MUST use the `-Z` parameter to patch, otherwise they will trigger autoreconf. And, for the sake of acknowledgment, let's use the patch from GitLab as well. R +20 -2 3rdparty/ext_fontconfig/0001-Fix-FC_DEFAULT_FONTS-on-macOS.patch [from: 3rdparty/ext_fontconfig/macOS_sedErrorFix.diff - 060% similarity] M +1 -1 3rdparty/ext_fontconfig/CMakeLists.txt https://invent.kde.org/graphics/krita/commit/2814f3f7a555b8359230e157c306dbd53576dddc The commit didn't fix the build because its modifications need to be precompiled with autoreconf (as they are applied to a tarball, not the git repo). For future reference, we need to document how to handle autotools-based patches. A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1278 Git commit 602e55754200d02dcd463b0d666a7bebaf4ec76b by Ivan Yossi, on behalf of L. E. Segovia. Committed on 05/01/2022 at 02:30. Pushed by ivany into branch 'master'. Fix patch for fontconfig triggering autoreconf Both .am and compiled files need to be updated. Let's also make sure their modification times don't change, either. M +40 -11 3rdparty/ext_fontconfig/0001-Fix-FC_DEFAULT_FONTS-on-macOS.patch https://invent.kde.org/graphics/krita/commit/602e55754200d02dcd463b0d666a7bebaf4ec76b |