Bug 447754

Summary: konsole --hide-tabbar broken by 372c14da6
Product: [Applications] konsole Reporter: Duncan <1i5t5.duncan>
Component: generalAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED FIXED    
Severity: normal CC: martin.sandsmark
Priority: NOR Keywords: regression
Version: master   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: https://invent.kde.org/utilities/konsole/commit/5599412002927be4c88d265c923b01ad54f7da16 Version Fixed In:
Sentry Crash Report:
Attachments: attachment-30509-0.html

Description Duncan 2021-12-31 21:21:26 UTC 
I have a scripted use-case[1] that uses konsole's --hide-tabbar command-line option.

After my last update the tabbar suddenly started appearing again, despite the script still containing konsole --hide-tabbar.  I bisected it to:

commit 372c14da6
Author:     Martin T. H. Sandsmark <martin.sandsmark@kde.org>
AuthorDate: Thu Oct 29 12:51:23 2020 +0100
Commit:     Tomaz  Canabrava <tcanabrava@kde.org>
CommitDate: Wed Dec 29 13:05:00 2021 +0000

Fix passing command line arguments in single-process mode.

Fixes --workdir with relative paths with single process.


In case it matters I'm using the live-git ebuilds for frameworks/plasma/apps all three from the gentoo/kde project overlay, and run konsole on plasma/kwin-wayland.

---
[1] The use-case is the TUI pdmenu used as a popup menu.  pdmenu allows configuring its colors, and  the rest of the konsole window is either turned off, as here with --hide-tabbar and with a window rule to set it titlebarless, or set transparent, creating the illusion of a standalone popup.  Any other (non-transparent) konsole component appearing destroys the illusion of a popup so is both horribly ugly and immediately noticeable.
Comment 1 Duncan 2021-12-31 21:30:31 UTC 
CCing Martin as author.  Bugzi doesn't appear to know tcannabrava's address so won't let me CC it.
Comment 2 Duncan 2021-12-31 21:41:00 UTC 
Since the commit mentions it... I do *not* run single-process mode.
Comment 3 tcanabrava 2022-01-01 09:41:39 UTC 
Created attachment 145004 [details]
attachment-30509-0.html

Yet another failure to fix multi process mode / single process mode.
Without this we have broken code for other stuff, since the code is from
Martin sandsmark I’ll wait a bit for his input.


Le ven. 31 déc. 2021 à 21:41, Duncan <bugzilla_noreply@kde.org> a écrit :

> https://bugs.kde.org/show_bug.cgi?id=447754
>
> --- Comment #2 from Duncan <1i5t5.duncan@cox.net> ---
> Since the commit mentions it... I do *not* run single-process mode.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
Comment 4 Duncan 2022-01-13 07:39:01 UTC 
Two-week status update.

So until now I had been locking konsole to the previous commit (because it's easier on gentoo), instead of reverting 372c14da6, but was dropping further behind current HEAD as a result.  I finally got around to trying an actual 372c14da6 revert against now-current HEAD.

It both still successfully reverts and continues to fix the bug.

Otherwise still awaiting Martin's comments as the author of the culprit commit.  As the bug was filed over the new-year's holiday maybe the original emails CCing him got lost...
Comment 5 Kurt Hindenburg 2022-01-14 16:07:08 UTC 
Git commit 5599412002927be4c88d265c923b01ad54f7da16 by Kurt Hindenburg.
Committed on 14/01/2022 at 16:01.
Pushed by hindenburg into branch 'master'.

Revert "Fix passing command line arguments in single-process mode."

This reverts commit 372c14da6ad480448b16ed6dd9daa5b784cb2d7f.

https://invent.kde.org/utilities/konsole/-/merge_requests/261
Related: bug 448414

M  +28   -46   src/Application.cpp
M  +1    -1    src/Application.h

https://invent.kde.org/utilities/konsole/commit/5599412002927be4c88d265c923b01ad54f7da16