Bug 447607

Summary: Make playListNotification more like Plasma notifications
Product: [Applications] Elisa Reporter: Jack Hill <jackhill3103>
Component: generalAssignee: Nate Graham <nate>
Status: RESOLVED FIXED    
Severity: wishlist CC: nate
Priority: NOR    
Version First Reported In: 21.12.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/multimedia/elisa/commit/68d40f2df4fb4104f46e8a39748571630bbdd14a Version Fixed/Implemented In: 22.04
Sentry Crash Report:

Description Jack Hill 2021-12-28 17:15:57 UTC 
SUMMARY
Currently playListNotification appears as a toast message for 7 seconds and then disappears.
There is no indication of how long the message is going to last for and hovering the mouse over the message doesn't pause or reset that timer.

STEPS TO REPRODUCE
1. Add a song to the current playlist
2. Click "Clear All"
3. Look at the toast notification that appears

OBSERVED RESULT
The toast disappears after 7 seconds

EXPECTED RESULT
Two suggestions (basically what Plasma notifications do):
- have a circular countdown timer around the close button to indicate when the message will disappear
- pause or reset the timer when the mouse hovers over the toast

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Tumbleweed 20211226
KDE Plasma Version: 5.23.4
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
As a side note, I feel like the auto-delete feature of playListNotification could be upstreamed to Kirigami.InlineMessage and then these suggestions could be used by other projects.
Comment 1 Nate Graham 2022-01-12 00:27:46 UTC 
A better solution might simply be to use an actual toast-style message instead of faking one using InlineMessage.
Comment 2 Nate Graham 2022-01-14 04:58:19 UTC 
Working on this.
Comment 3 Nate Graham 2022-01-14 05:25:56 UTC 
WIP branch, just one more bug to figure out and then I'll submit a merge request.

https://invent.kde.org/multimedia/elisa/-/tree/work/ngraham/port-to-passivenotification
Comment 4 Bug Janitor Service 2022-01-23 04:51:33 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/320
Comment 5 Nate Graham 2022-01-27 20:19:32 UTC 
Git commit 68d40f2df4fb4104f46e8a39748571630bbdd14a by Nate Graham.
Committed on 27/01/2022 at 20:13.
Pushed by ngraham into branch 'master'.

Port Playlist inlinemessages to PassiveNotification

We were basically replicating the functionality; might as well just use
the real thing. Then we can benefit from future improvements and have
less custom code.

The connections to the model's signal are moved into ElisaMainWindow so
that they are made only once, not once per instantiation of
MediaPlayListView. That caused logic to be executed twice.
FIXED-IN: 22.04

M  +2    -7    src/mediaplaylistproxymodel.cpp
M  +11   -0    src/qml/ElisaMainWindow.qml
M  +1    -110  src/qml/MediaPlayListView.qml

https://invent.kde.org/multimedia/elisa/commit/68d40f2df4fb4104f46e8a39748571630bbdd14a