Bug 447520

Summary:	AppData screenshot links are broken
Product:	[Applications] krita	Reporter:	Long Vu <hi>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	5.0.0
Target Milestone:	---
Platform:	Flatpak
OS:	Linux
Latest Commit:	https://invent.kde.org/websites/product-screenshots/commit/5c912c8b4b419b3c74429d3a192010dddaa988ea	Version Fixed/Implemented In:
Sentry Crash Report:

Description Long Vu 2021-12-26 00:08:10 UTC

SUMMARY
The appdata file org.kde.krita.appdata.xml contains multiple screenshots, however the links for the screenshots do not lead to a file that exists resulting in a build failure on flathub.

builddir/files/share/appdata/org.kde.krita.appdata.xml: FAILED:
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://cdn.kde.org/screenshots/krita/animation.png]
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://cdn.kde.org/screenshots/krita/gmic.png]
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://cdn.kde.org/screenshots/krita/manual.png]
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://cdn.kde.org/screenshots/krita/youtube.png]
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://cdn.kde.org/screenshots/krita/splash.png]
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://cdn.kde.org/screenshots/krita/filters.png]
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://cdn.kde.org/screenshots/krita/community.png]
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://cdn.kde.org/screenshots/krita/welcome.png]
Validation of files failed

Comment 1 Halla Rempt 2022-01-04 14:42:30 UTC

Git commit 5c912c8b4b419b3c74429d3a192010dddaa988ea by Halla Rempt.
Committed on 04/01/2022 at 14:42.
Pushed by rempt into branch 'master'.

Update krita screenshots

D  +-    --    krita/2018-03-17_screenshot_001.png
D  +-    --    krita/2018-03-17_screenshot_002.png
D  +-    --    krita/2018-03-17_screenshot_003.png
D  +-    --    krita/2018-03-17_screenshot_004.png
D  +-    --    krita/2018-03-17_screenshot_005.png
D  +-    --    krita/2018-03-17_screenshot_006.png
A  +-    --    krita/alexandru_sabo.png
A  +-    --    krita/animation.png
A  +-    --    krita/brush_editor.png
A  +-    --    krita/community.png
A  +-    --    krita/filters.png
A  +-    --    krita/gmic.png
A  +-    --    krita/loentar.png
A  +-    --    krita/manual.png
A  +-    --    krita/negeon_renj.png
A  +-    --    krita/raghukamath.png
A  +-    --    krita/scripting.png
A  +-    --    krita/simon_rollins.png
A  +-    --    krita/splash.png
A  +-    --    krita/tiled_windows_wojtrb_raghu.png
A  +-    --    krita/welcomepage.png
A  +-    --    krita/youtube.png

https://invent.kde.org/websites/product-screenshots/commit/5c912c8b4b419b3c74429d3a192010dddaa988ea

Comment 2 Long Vu 2022-01-04 17:06:05 UTC

Should the link for welcome.png be changed to welcomepage.png in the appdata file?

Comment 3 Halla Rempt 2022-01-05 09:58:19 UTC

Git commit a5b9e6204a693bb741a81150faf968583fa16063 by Halla Rempt.
Committed on 05/01/2022 at 09:58.
Pushed by rempt into branch 'master'.

Fix link to welcomepage.png

M  +1    -1    krita/org.kde.krita.appdata.xml

https://invent.kde.org/graphics/krita/commit/a5b9e6204a693bb741a81150faf968583fa16063

Comment 4 Long Vu 2022-01-08 22:53:03 UTC

Looks like the build is failing on one of the screenshots currently.

builddir/files/share/appdata/org.kde.krita.appdata.xml: FAILED:
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_002.png]
Validation of files failed

Comment 5 Halla Rempt 2022-01-09 10:46:54 UTC

Git commit b66d62dd54383886a6b05b007530489f8aae8ab0 by Halla Rempt.
Committed on 09/01/2022 at 10:46.
Pushed by rempt into branch 'master'.

Update two screenshot links

M  +2    -2    krita/org.kde.krita.appdata.xml

https://invent.kde.org/graphics/krita/commit/b66d62dd54383886a6b05b007530489f8aae8ab0

Comment 6 Halla Rempt 2022-01-09 10:49:02 UTC

Git commit e2cfa7654992df1f63c4cacddf86d8fc6eab9e7b by Halla Rempt.
Committed on 09/01/2022 at 10:48.
Pushed by rempt into branch 'krita/5.0'.

Update screenshots

M  +88   -45   krita/org.kde.krita.appdata.xml

https://invent.kde.org/graphics/krita/commit/e2cfa7654992df1f63c4cacddf86d8fc6eab9e7b

Comment 7 Long Vu 2022-01-09 19:07:09 UTC

There might be a typo with "brusheditor.png" in the recent commits. The file is named "brush_editor.png" on the KDE CDN.