Bug 447473

Summary: Cannot disable completely under/over-exposure was enable when launching "Adjust Curve"
Product: [Applications] digikam Reporter: Alexandre Belz <alexandre.belz>
Component: ImageEditor-CoreAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 7.3.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In: 7.5.0
Sentry Crash Report:
Attachments: Screen capture of the issue. See bottom right the 2x buttons disengaged.

Description Alexandre Belz 2021-12-24 15:09:38 UTC
Created attachment 144833 [details]
Screen capture of the issue. See bottom right the 2x buttons disengaged.

SUMMARY
***
Under/over-exposure refuse to disengage during "Adjust Curve", if it was enabled when starting adjusting.
***


STEPS TO REPRODUCE
1. I open the picture enclosed in Image Editor. 
2. Under/Over exposure tool (2x little buttons at the bottom right) works as expected
3. select both under and over adjustment tool.
4. Select the "Adjust Curve", do not adjust anything.
5. try to remove the Under/Over exposure visualization.

OBSERVED RESULT
Under/over-exposure remains activated, even if the little buttons are released.
See "capture.jpg" file enclosed.

EXPECTED RESULT
I think that  under/over-exposure should disengage when the little buttons are released.
(so that we can see the rendering even in shadows/highlights).

SOFTWARE/OS VERSIONS
Windows: 10

ADDITIONAL INFORMATION
Comment 1 caulier.gilles 2021-12-24 15:29:27 UTC
Problem cannot be reproduced with 7.4.0 under MacOS...

Gilles Caulier
Comment 2 Maik Qualmann 2021-12-24 15:38:47 UTC
When a tool is open, the buttons for displaying the over / under exposure no longer have any effect on the tool preview.

Maik
Comment 3 Maik Qualmann 2021-12-24 15:41:37 UTC
Ok, if I change the tool settings and a new preview has to be rendered, the new button settings are applied.

Maik
Comment 4 Maik Qualmann 2021-12-24 16:13:12 UTC
Git commit 2797d1278be01250bd38e1c3c385d660c76290ee by Maik Qualmann.
Committed on 24/12/2021 at 16:10.
Pushed by mqualmann into branch 'master'.

fix apply exposure settings in the ImageRegionWidget
FIXED-IN: 7.5.0

M  +1    -0    core/utilities/imageeditor/widgets/imageregionwidget.cpp

https://invent.kde.org/graphics/digikam/commit/2797d1278be01250bd38e1c3c385d660c76290ee
Comment 5 Alexandre Belz 2021-12-24 16:17:22 UTC
Whoo, that's an express bug resolution !
Many thanks Maik !
Comment 6 Maik Qualmann 2021-12-25 08:18:43 UTC
Git commit 3f2631f7533354b2aa61c0c59c4159886bba93e0 by Maik Qualmann.
Committed on 25/12/2021 at 08:17.
Pushed by mqualmann into branch 'master'.

faster update of exposure settings

M  +10   -10   core/utilities/imageeditor/widgets/imageregionwidget.cpp

https://invent.kde.org/graphics/digikam/commit/3f2631f7533354b2aa61c0c59c4159886bba93e0