| Summary: | Crash with: New... + Flatten image + Elliptical selection + Trim to selection + ("Undo History" docker) click on "<empty>" | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | mvowada <freebox64> |
| Component: | General | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | dimula73, raghu |
| Priority: | NOR | ||
| Version: | 5.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Appimage | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/36c9e609cd2e2af3a2c92452de97152423aa73bc | Version Fixed In: | |
| Attachments: |
GDB report
Video example. Full backtrace of the dev build |
||
|
Description
mvowada
2021-12-24 11:15:42 UTC
Created attachment 144826 [details]
Video example.
I can reproduce the issue on all platforms Created attachment 144827 [details]
Full backtrace of the dev build
Git commit 8f9293b5f1da0ba83296676cbe46ef9662527848 by Dmitry Kazakov. Committed on 27/12/2021 at 13:26. Pushed by dkazakov into branch 'master'. Fix a crashes when undoing multiple layer operations too quickly This patch solve the whole bunch of issues that happened when the dummies graph was updated too quickly: 1) Implements a clever strategy for processing not-yet-added nodes in KisDummiesFacadeBase::setImage(). Instead of just asserting on detection of such nodes, we track a "theoretical" set of nodes that will be present in the dummies graph after all synchronized connections are executed. 2) KisSynchronizedConnectionBase::postEvent() will not bariier-sync with the main events queue when the event is processed in the GUI thread. 3) Fixes minor mutex usage issues in KisSynchronizedConnection 4) KisNodeModel will no longer try to fetch a thumbnail from the layer that has been removed from the image. M +17 -0 libs/global/KisSynchronizedConnection.cpp M +16 -6 libs/global/KisSynchronizedConnection.h M +23 -15 libs/ui/KisApplication.cpp M +2 -0 libs/ui/KisApplication.h M +28 -7 libs/ui/flake/kis_dummies_facade_base.cpp M +14 -1 libs/ui/kis_node_model.cpp https://invent.kde.org/graphics/krita/commit/8f9293b5f1da0ba83296676cbe46ef9662527848 Git commit bb1ab7ea46b35851549da5432fc4600a95af1db9 by Dmitry Kazakov. Committed on 27/12/2021 at 13:30. Pushed by dkazakov into branch 'krita/5.0'. Fix a crashes when undoing multiple layer operations too quickly This patch solve the whole bunch of issues that happened when the dummies graph was updated too quickly: 1) Implements a clever strategy for processing not-yet-added nodes in KisDummiesFacadeBase::setImage(). Instead of just asserting on detection of such nodes, we track a "theoretical" set of nodes that will be present in the dummies graph after all synchronized connections are executed. 2) KisSynchronizedConnectionBase::postEvent() will not bariier-sync with the main events queue when the event is processed in the GUI thread. 3) Fixes minor mutex usage issues in KisSynchronizedConnection 4) KisNodeModel will no longer try to fetch a thumbnail from the layer that has been removed from the image. M +17 -0 libs/global/KisSynchronizedConnection.cpp M +16 -6 libs/global/KisSynchronizedConnection.h M +23 -15 libs/ui/KisApplication.cpp M +2 -0 libs/ui/KisApplication.h M +28 -7 libs/ui/flake/kis_dummies_facade_base.cpp M +14 -1 libs/ui/kis_node_model.cpp https://invent.kde.org/graphics/krita/commit/bb1ab7ea46b35851549da5432fc4600a95af1db9 Git commit 36c9e609cd2e2af3a2c92452de97152423aa73bc by Dmitry Kazakov. Committed on 27/12/2021 at 13:41. Pushed by dkazakov into branch 'krita/5.0.0'. Fix a crashes when undoing multiple layer operations too quickly This patch solve the whole bunch of issues that happened when the dummies graph was updated too quickly: 1) Implements a clever strategy for processing not-yet-added nodes in KisDummiesFacadeBase::setImage(). Instead of just asserting on detection of such nodes, we track a "theoretical" set of nodes that will be present in the dummies graph after all synchronized connections are executed. 2) KisSynchronizedConnectionBase::postEvent() will not bariier-sync with the main events queue when the event is processed in the GUI thread. 3) Fixes minor mutex usage issues in KisSynchronizedConnection 4) KisNodeModel will no longer try to fetch a thumbnail from the layer that has been removed from the image. M +17 -0 libs/global/KisSynchronizedConnection.cpp M +16 -6 libs/global/KisSynchronizedConnection.h M +23 -15 libs/ui/KisApplication.cpp M +2 -0 libs/ui/KisApplication.h M +28 -7 libs/ui/flake/kis_dummies_facade_base.cpp M +14 -1 libs/ui/kis_node_model.cpp https://invent.kde.org/graphics/krita/commit/36c9e609cd2e2af3a2c92452de97152423aa73bc *** Bug 439023 has been marked as a duplicate of this bug. *** |