Bug 447286

Summary: Plug-in built without community filters enabled by default
Product: [Applications] krita Reporter: David Tschumperlé <David.Tschumperle>
Component: G'Mic for KritaAssignee: amyspark <amy>
Status: RESOLVED FIXED    
Severity: normal CC: amy
Priority: NOR    
Version First Reported In: 5.0.0-beta5   
Target Milestone: ---   
Platform: Other   
OS: Linux   
URL: https://github.com/c-koi/gmic-qt/pull/129
Latest Commit: https://invent.kde.org/graphics/krita/commit/25f67fc173b3d425113bea67a46078dbd9b59a3c Version Fixed/Implemented In:
Sentry Crash Report:

Description David Tschumperlé 2021-12-20 14:28:56 UTC 
SUMMARY

On Krita 5 (appimage) :  When opening the G'MIC plug-in (v.3.0) without being connected to the network, the plug-in shows "only" 410 filters available. With latest version 3.0 of G'MIC, there is a macro `gmic_community` that can be enabled during the compilation, in order to include all default + community filters (approx. 575 filters), which is actually what you get when the plug-in updates its list of filters from the network (done automatically most of the time, but fails sometimes if user is behind a firewall).

STEPS TO REPRODUCE
1.  Remove previous update file (`$ rm $HOME/.config/gmic/update300.gmic`)
2. Disconnect from network
3. Open an image in Krita then the G'MIC plug-in

OBSERVED RESULT
G'MIC displays 410 available filters

EXPECTED RESULT
G'MIC displays **575** available filters


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 amyspark 2021-12-21 14:27:45 UTC 
Hi David!

> With latest version 3.0 of G'MIC, there is a macro `gmic_community` that can be enabled during the compilation

This is missing from Sébastien's CMakeLists.txt, see https://github.com/c-koi/gmic-qt/commit/fa33973a0e8f31d3a859319999e86a681aa27227 and https://github.com/c-koi/gmic-qt/blob/c82502c2a20d321be8770d8e2cf814feebe61a22/CMakeLists.txt#L284-L289.
Comment 2 David Tschumperlé 2021-12-21 14:40:37 UTC 
Interesting, thanks! We actually don't use the CMakefiles to compile the plug-in for the releases (we use the 'old' qmake way).
I'll fill an issue for Seb, to let him know that the macro is missing there.
Thanks!
Comment 3 David Tschumperlé 2021-12-21 14:45:54 UTC 
(In reply to David Tschumperlé from comment #2)
> Interesting, thanks! We actually don't use the CMakefiles to compile the
> plug-in for the releases (we use the 'old' qmake way).
> I'll fill an issue for Seb, to let him know that the macro is missing there.
> Thanks!

Here it is : https://github.com/c-koi/gmic-qt/pull/129
Comment 4 amyspark 2021-12-21 16:37:48 UTC 
On second thought, I'll keep it open until we merge the changes from 3.0.1.
Comment 5 Bug Janitor Service 2021-12-23 17:19:49 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1255
Comment 6 amyspark 2021-12-24 11:32:57 UTC 
Git commit 0aced718ebe7845d26e4a881f0ef6cc139c6abe5 by L. E. Segovia.
Committed on 24/12/2021 at 11:30.
Pushed by lsegovia into branch 'master'.

Update G'MIC to 3.0.0 patch 2
Related: bug 447290

M  +2    -2    3rdparty_plugins/ext_gmic/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/0aced718ebe7845d26e4a881f0ef6cc139c6abe5
Comment 7 amyspark 2021-12-24 11:39:06 UTC 
Git commit 25f67fc173b3d425113bea67a46078dbd9b59a3c by L. E. Segovia.
Committed on 24/12/2021 at 11:33.
Pushed by lsegovia into branch 'krita/5.0'.

Update G'MIC to 3.0.0 patch 2
Related: bug 447290
(cherry picked from commit 0aced718ebe7845d26e4a881f0ef6cc139c6abe5)

M  +2    -2    3rdparty_plugins/ext_gmic/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/25f67fc173b3d425113bea67a46078dbd9b59a3c