Bug 447269

Summary:	Closing the Get New Stuff dialog doesn't really close it, it's still in the background. All errors from before come back when it's reopened. The only way to close it is to close System Settings
Product:	[Frameworks and Libraries] frameworks-knewstuff	Reporter:	strangequark <random1123581321>
Component:	general	Assignee:	Dan Leinir Turthra Jensen <admin>
Status:	CONFIRMED ---
Severity:	normal	CC:	alexander.lohnau, kdelibs-bugs-null, nate
Priority:	NOR
Version First Reported In:	5.90.0
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description strangequark 2021-12-20 10:42:04 UTC

SUMMARY
As in the title; Get New Stuff doesn't really close when it's closed, as any errors that happened will come back when you reopen the dialog

STEPS TO REPRODUCE
1. Get it to error out
2. Close and reopen the window 

OBSERVED RESULT
It remains open in the background, because any errors that were previously displayed are still there.

EXPECTED RESULT
It should actually close when the close button is pressed

SOFTWARE/OS VERSIONS
Operating System: Fedora Linux 35
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Graphics Platform: X11

ADDITIONAL INFORMATION
none

Comment 1 Nate Graham 2022-01-11 22:19:39 UTC

Not quite entirely fixed by https://invent.kde.org/frameworks/knewstuff/-/commit/0f324aa1dea282dbf04f05b955e91530dff03d83; we'd need to mark the loader with `active: false` once the dialog is closed.

Comment 2 Alexander Lohnau 2022-01-12 07:26:40 UTC

I though we did not want to re-create the dialog and thus re-create the KNS engine when one closes and opens the dialog.

>because any errors that were previously displayed are still there.

Could you post a screenshot of the errors?

>It should actually close when the close button is pressed

There is a difference between close and quit ;)

Comment 3 strangequark 2022-01-14 07:43:36 UTC

(In reply to Alexander Lohnau from comment #2)
> I though we did not want to re-create the dialog and thus re-create the KNS
> engine when one closes and opens the dialog.
> 
> >because any errors that were previously displayed are still there.
> 
> Could you post a screenshot of the errors?
> 
> >It should actually close when the close button is pressed
> 
> There is a difference between close and quit ;)

I do not have a screenshot of the errors at the moment, but this bug is also irritating when something is being installed. Install something from the window, and while it is being installed close both the Get New Stuff window and the System Settings window itself. Now, System Settings refuses to open (when launched) until whatever you were installing has finished.