| Summary: | Transform Mask make wrong calculation with perspective with a 90degree turn | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Alexey <o-din13> |
| Component: | Tools/Transform | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahab.greybeard, dimula73 |
| Priority: | NOR | ||
| Version: | 5.0.0-beta2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/d2cd5b2024553863eb57273c17c087c3eb905bee | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
perspective with a 90degree turn
with fill layer same t.mask on paint layer Video: The control handle does not want to be moved |
||
Created attachment 144705 [details]
with fill layer
Created attachment 144707 [details]
same t.mask on paint layer
Just a note, this bug is reproducible in Krita 4.4.7, so it is not a regression. Created attachment 144714 [details]
Video: The control handle does not want to be moved
Confirmed with the Dec 19 5.1.0-prealpha (git 5e7b12a) appimage on Debian 10.
The transform preview is good and the final image, after the transform is finalised, is good for a couple of seconds before the fine detail distortion appears.
While making the transform, there is some difficulty with moving the control handles in the final stages of the 90 degree rortaion.
They snap back when you try to move them
A video example of this is attached.
Git commit 634b939438e3cd2f5e16d744ff043bf8fd7d9674 by Dmitry Kazakov. Committed on 20/12/2021 at 16:28. Pushed by dkazakov into branch 'master'. Fix blurry results in 4-point Perspective Transform mode It looks like if we try to apply the transform in two stages, the intermediate image gets collapsed into a few-pixels-wide chunk and therefore causing the final image to be extremely blurry. M +30 -29 plugins/tools/tool_transform2/kis_perspective_transform_strategy.cpp M +6 -0 plugins/tools/tool_transform2/kis_transform_utils.cpp https://invent.kde.org/graphics/krita/commit/634b939438e3cd2f5e16d744ff043bf8fd7d9674 Git commit d2cd5b2024553863eb57273c17c087c3eb905bee by Dmitry Kazakov. Committed on 20/12/2021 at 16:32. Pushed by dkazakov into branch 'krita/5.0'. Fix blurry results in 4-point Perspective Transform mode It looks like if we try to apply the transform in two stages, the intermediate image gets collapsed into a few-pixels-wide chunk and therefore causing the final image to be extremely blurry. (cherry picked from commit 634b939438e3cd2f5e16d744ff043bf8fd7d9674) M +30 -29 plugins/tools/tool_transform2/kis_perspective_transform_strategy.cpp M +6 -0 plugins/tools/tool_transform2/kis_transform_utils.cpp https://invent.kde.org/graphics/krita/commit/d2cd5b2024553863eb57273c17c087c3eb905bee Just a note: if you have an existing file with the 4-point perspective transform as a transform mask, please activate transform tool on it and move any handle a little bit. That will update a transform saved in the transform mask, so the blurry effect will go away. |
Created attachment 144704 [details] perspective with a 90degree turn Transform Mask make wrong calculation with perspective with a 90degree turn STEPS TO REPRODUCE 1. Add Transform Mask 2. Get perspective transform 3. Rotate it by 90° or open attachment ::) OBSERVED RESULT Glitched image with perspective transform EXPECTED RESULT Normal image with perspective transform SOFTWARE/OS VERSIONS Krita 4.4.7, ANGLE, OpenGL, Win7x62 sp1 Krita 5.0.0-beta5, OpenGL, Linux Mint 19.2