Bug 447107

Summary:	MacOS: [Shift + Click] Fails to Select Multiple Frames in Animation Timeline
Product:	[Applications] krita	Reporter:	vanyossi <ghevan>
Component:	Animation	Assignee:	vanyossi <ghevan>
Status:	CONFIRMED ---
Severity:	normal	CC:	emmetoneill.pdx, eoinoneill1991, oliverpete, random90s
Priority:	NOR
Version:	5.0.0-beta5
Target Milestone:	---
Platform:	Other
OS:	macOS
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description vanyossi 2021-12-17 06:05:56 UTC

click and then shift + click to select a bunch of consecutive frames in animation docker fails. I shows the selection is done for 5ms and then it deselects all.

This is for macOS version
confirming https://krita-artists.org/t/fifth-5-beta-of-krita-5-0-released/32791/5

Comment 1 wolthera 2021-12-17 13:59:01 UTC

*** Bug 446507 has been marked as a duplicate of this bug. ***

Comment 2 vanyossi 2021-12-17 18:11:25 UTC

This seems to be related to how different stylus and mouse/trackpad events are on macOS.

I set a couple of debugs and using trackpad the shift+click works as expected with the modifier reported as "pan-zoom" at

bool KisCustomModifiersCatcher::modifierPressed(const QString &id)

This changes if I drag to trigger "startDrag" "offset-frame" action and work correctly on mouse and trackpad, this triggers two "pan-zoom", one on mouseclick and the other on mouseRelease. However using the stylus, as this tool sends constant updates from its position, a single click is seen as a move operation and "pan-zoom" is registered 3 times before triggering "offset-frame", by that time the stylus is up, and the chunk of frames is moved to the same place.

I am not familiar with this part of the code but I think we can avoid this issue either compressing stylus events on the timeline docker, or adding a delay for registering movement to the stylus events.

Comment 3 random90s 2022-03-09 15:38:00 UTC

Still experiencing this is 5.0.2. Works fine in 4.4.2 though. ^^

Comment 4 Eoin O'Neill 2022-03-10 21:24:31 UTC

(In reply to vanyossi from comment #2)
> This seems to be related to how different stylus and mouse/trackpad events
> are on macOS.

Just to confirm, this is only an issue on MacOS correct?

I haven't had any issues with shift + click on tablet or on mouse on my linux machine or windows machine...