Bug 446955

Summary:	We have both 'Status' and 'ResourceActive' data roles, which duplicate functionality.
Product:	[Applications] krita	Reporter:	wolthera <griffinvalley>
Component:	Resource Management	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	halla
Priority:	NOR
Version First Reported In:	5.0.0-beta2
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/-/commit/bb50021f93bff31c709dff1a8aaf56166156a14b	Version Fixed/Implemented In:
Sentry Crash Report:

Description wolthera 2021-12-13 22:15:55 UTC

SUMMARY
When trying to fix a bug with the preset history docker, I noticed we have both a KisResourceModel::Status and KisResourceModel::ResourceActive, and we only store the former. We also have KisResourceModel::StorageActive, which is also not stored, so I am not sure what it does?

I guess the latter two need to be removed, but it's nearing midnight, and one of them is referenced in the tests.

Comment 1 Halla Rempt 2021-12-14 07:54:03 UTC

Status and ResourceActive are duplicates, StorageActive reflects whether the storage the resource is in is active.

Comment 2 Halla Rempt 2023-06-15 11:23:49 UTC

Git commit bb50021f93bff31c709dff1a8aaf56166156a14b by Halla Rempt.
Committed on 15/06/2023 at 11:22.
Pushed by rempt into branch 'master'.

Note that Status and ResourceActive are duplicates

M  +1    -0    libs/resources/KisResourceModel.h

https://invent.kde.org/graphics/krita/-/commit/bb50021f93bff31c709dff1a8aaf56166156a14b