Bug 446900

Summary: Changing command line options for lame does not work (ripping mp3 from CD)
Product: [Applications] k3b Reporter: grzebo
Component: CopyingAssignee: k3b developers <k3b>
Status: RESOLVED FIXED    
Severity: normal CC: aacid, michalm, trueg
Priority: NOR    
Version: 21.08.3   
Target Milestone: ---   
Platform: Kubuntu   
OS: Linux   
Latest Commit: https://invent.kde.org/multimedia/k3b/commit/bb5aedb0d80db412e4404fcc1ed6f23160280008 Version Fixed In:
Sentry Crash Report:

Description grzebo 2021-12-12 21:54:59 UTC 
SUMMARY

K3B has an option to manually edit command line options that should be passed to lame when encoding mp3 (ripping audio CD). Those options do not work: no matter what is inserted into the command line, the resulting mp3 have a bitrate of 128 kbps.


STEPS TO REPRODUCE
1. insert audio CD, open a dialog to copy it (rip it) to harddrive
2. choose "Lame (mp3)" as the desired output and click on the configuration button to edit options
3.  default options are:
lame -r --bitwidth 16 --little-endian -s 44.1 -h --tt %t --ta %a --tl %m --ty %y --tc %c --tn %n

change them to:
lame -r --bitwidth 16 --little-endian -s 44.1 --preset insane --tt %t --ta %a --tl %m --ty %y --tc %c --tn %n

or use -V 0, or use - b 192, or use any other options which should force lame to encode mp3's with higher bitrate than 128 kbps.

4. Rip the CD

OBSERVED RESULT
All the resulting mp3's are 128 kbps, no matter what options were used. 

EXPECTED RESULT
Resulting mp3's should be encoded using the options that were specified, which should be passed to lame.

SOFTWARE/OS VERSIONS
Kubuntu 20.10

ADDITIONAL INFORMATION
The built-in mp3 encoder always encodes with 28 kbps and ignores unicode in id3 tags, so it's even worse.
Comment 1 Albert Astals Cid 2021-12-12 22:45:08 UTC 
I think i may have found the problem, can you confirm that if you go to settings->configure k3b->plugins and configure lame there it actually changes the way the ripping happens?
Comment 2 Albert Astals Cid 2021-12-12 22:55:41 UTC 
Ah no, that only effects the "MPEG1 Layer III (mp3)" option
Comment 3 Albert Astals Cid 2021-12-12 23:00:23 UTC 
ok, as a quick workaround you can edit the command, close the app, open it again and then it should use the new command you set.
Comment 4 Bug Janitor Service 2021-12-12 23:22:11 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/k3b/-/merge_requests/20
Comment 5 Albert Astals Cid 2021-12-23 21:48:34 UTC 
Git commit bb5aedb0d80db412e4404fcc1ed6f23160280008 by Albert Astals Cid.
Committed on 23/12/2021 at 21:48.
Pushed by aacid into branch 'release/21.12'.

Fix changing command line encoder options not having effect until app restart

We have two plugins using the same config files so we need to reparse
the config each time we access it since it may have been changed by the
other plugin

M  +2    -0    plugins/encoder/external/k3bexternalencodercommand.cpp

https://invent.kde.org/multimedia/k3b/commit/bb5aedb0d80db412e4404fcc1ed6f23160280008