Bug 446792

Summary: New brush presets seem to use last selected brush's thumbnail by default
Product: [Applications] krita Reporter: wolthera <griffinvalley>
Component: Brush enginesAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version: 5.0.0-beta2   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/krita/-/commit/c1e51b4020d95433851144da92172b790466edc7 Version Fixed In:
Sentry Crash Report:

Description wolthera 2021-12-10 17:11:57 UTC 
SUMMARY
When saving a new brush preset for an engine, the last selected brush' thumbnail will be used.


STEPS TO REPRODUCE
1. Select a preset
2. Use the plus in the brush settings dialog to create a new preset for an unrelated engine.
3. Save preset. 

OBSERVED RESULT
The thumbnail of the brush selected at 1. will be used as the preset image.

EXPECTED RESULT
I'm not sure... I guess I was expecting a blank image, because the default presets for each engine have a blank image.
Comment 1 Dmitry Kazakov 2024-10-24 12:35:57 UTC 
Git commit 429bb8493b4c11ae28888b79f21dff3c56e7ef0b by Dmitry Kazakov.
Committed on 24/10/2024 at 12:35.
Pushed by dkazakov into branch 'master'.

Fix the current preset thumbnail to be present in the preset save dialog

We shouldn't update the thumb separately, just load it every time when the dialog
is open (in the end, it doesn't happen too often).
Related: bug 488673

M  +0    -3    libs/ui/kis_paintop_box.cc
M  +7    -6    libs/ui/widgets/kis_paintop_presets_editor.cpp
M  +0    -4    libs/ui/widgets/kis_paintop_presets_editor.h

https://invent.kde.org/graphics/krita/-/commit/429bb8493b4c11ae28888b79f21dff3c56e7ef0b
Comment 2 Dmitry Kazakov 2024-10-24 12:36:18 UTC 
Git commit c1e51b4020d95433851144da92172b790466edc7 by Dmitry Kazakov.
Committed on 24/10/2024 at 12:36.
Pushed by dkazakov into branch 'krita/5.2'.

Fix the current preset thumbnail to be present in the preset save dialog

We shouldn't update the thumb separately, just load it every time when the dialog
is open (in the end, it doesn't happen too often).
Related: bug 488673

M  +0    -2    libs/ui/kis_paintop_box.cc
M  +7    -6    libs/ui/widgets/kis_paintop_presets_editor.cpp
M  +0    -4    libs/ui/widgets/kis_paintop_presets_editor.h

https://invent.kde.org/graphics/krita/-/commit/c1e51b4020d95433851144da92172b790466edc7