| Summary: | Channel Settings, Modes tab "User Limit" QSpinBox uses default max=99, messing up any higher setting by /cmode +l NNN | ||
|---|---|---|---|
| Product: | [Applications] konversation | Reporter: | reisenweber |
| Component: | general | Assignee: | Konversation Developers <konversation-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 1.7.4 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/network/konversation/commit/074f80e2dcefdc6cd0b68714021481ee35b7df30 | Version Fixed In: | 1.8.21121 |
| Attachments: | screenshot dialog "channel settings modes" | ||
|
Description
reisenweber
2021-12-08 10:36:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/konversation/-/merge_requests/68 Git commit 074f80e2dcefdc6cd0b68714021481ee35b7df30 by Friedrich W. H. Kossebau. Committed on 18/12/2021 at 23:27. Pushed by kossebau into branch 'release/21.12'. Channel Settings UI: bump max value of "User limit" to 99999 Max value was the default 99, which would result in... a) any higher value read from the channel mode being reset to 99 b) not allow users to set higher values if wanted. As applying the channel settings from the dialog always picks all the values of the dialog, also those not edited, in case of a) this also would mean changing the user limit in the channel to 99 then. RFCs are not known to define a max user limit, so this is server defined. While there is no path explored to query any max user limit capabilities, and servers implementations seems to just map too high numbers to random possible ones, there is no well defined max value to be used for the dialog. Using 99999 as arbitrary value should serve for now all expected use-cases. To be raised later if there is respective feedback. FIXED-IN: 1.8.21121 M +3 -0 src/viewer/channeloptionsui.ui https://invent.kde.org/network/konversation/commit/074f80e2dcefdc6cd0b68714021481ee35b7df30 |